search

ubuntu / gnome-sdk

GNOME SDK/Platform snap
22 stars 24 forks source link

Store the debug symbols #55

Closed sergio-costas closed 2 years ago

sergio-costas commented 2 years ago

This patch stores in a separate file the debug symbols, like the https://github.com/ubuntu/gnome-sdk/pull/38 patch does for Gnome38.

kenvandine commented 2 years ago

Since this is very similar to the PR for gnome-3-38, it would be great to have @lissyx review this. @seb128 can you please take a look as well?

lissyx commented 2 years ago

Why was a different patch made ? If my PR is not good enough, I can fix it ...

sergio-costas commented 2 years ago

Your PR is for Gnome-3-38 snap, while this one is for Gnome-42. They are different branches. Also, since I was already stripping there the binaries, I just implemented the symbol storing directly in the python.

lissyx commented 2 years ago

Your PR is for Gnome-3-38 snap, while this one is for Gnome-42. They are different branches. Also, since I was already stripping there the binaries, I just implemented the symbol storing directly in the python.

Well, given firefox depends on gnome-3-38, I made the PR against that version because this is where we need it the most urgently.

Then we shoud just drop my PR and cherry-pick yours on gnome-3-38-sdk branch?

lissyx commented 2 years ago

Ok, previous branches did not have the strip_binaries. It's also unclear to me why there are all those -sdk and not -sdk branches. This one

sergio-costas commented 2 years ago

I don't think it is possible to do that: the gnome-3-38 branch is completely different and independent of the Gnome-42. @kenvandine...?

lissyx commented 2 years ago

But gnome-40-2004 branch does not seem to build any of the libs, I'm assuming it is build on the -sdk part? And this will be done on https://github.com/ubuntu/gnome-sdk/pull/54 ?

Does it means my current PR should be split the same way then ? Changing the build parameters to generate debug symbols on gnome-3-38-2004-sdk and collecting / strippping on gnome-3-38-2004 ?

sergio-costas commented 2 years ago

The Gnome-XX branches contain the snaps with the Gnome runtime for each Gnome version. They are needed for running programs. The Gnome-XX-SDK are for compiling programs and snapping them: they contain the compiler, libraries, headers and so on of an specific Gnome version. The Gnome-XX branches generate an snap with the same libraries than Gnome-XX-SDK, but without all the stuff needed to compile. This way, the programs don't need to include all the common Gnome libraries (like Gtk), but only those that are specific for them, or less used. And, of course, if you compiled a program with Gnome-3-38-SDK, it needs Gnome-3-38 snap; it can't run with, let's say, Gnome-42 snap.

Last week, trying to reduce the size of the Gnome-42 snap, we added binary stripping. And then we found your patch for Gnome-3-38 that stored the debug symbols in a separate file, and decided that the same should be done in Gnome-42 just in case they are needed. And that's why we modified the original patch to include storing the debug symbols also in Gnome-42.

I'm not sure if this answers your question...

lissyx commented 2 years ago

The Gnome-XX branches contain the snaps with the Gnome runtime for each Gnome version. They are needed for running programs. The Gnome-XX-SDK are for compiling programs and snapping them: they contain the compiler, libraries, headers and so on of an specific Gnome version. The Gnome-XX branches generate an snap with the same libraries than Gnome-XX-SDK, but without all the stuff needed to compile. This way, the programs don't need to include all the common Gnome libraries (like Gtk), but only those that are specific for them, or less used.

Last week, trying to reduce the size of the Gnome-42 snap, we added binary stripping. And then we found your patch for Gnome-3-38 that stored the debug symbols in a separate file, and decided that the same should be done in Gnome-42 just in case they are needed. And that's why we modified the original patch to include storing the debug symbols also in Gnome-42.

I'm not sure if this answers your question...

it does, I was waiting for a r+ on that before asking about other versions, to be honest, since I was first targetting what firefox uses, but it's clear having them on newer version will be useful either way, in the future for firefox or for others.