ubuntu / gnome-shell-communitheme

GNOME Shell Ubuntu community theme "communitheme"
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v2.0
147 stars 19 forks source link

Slider consistency part II #132

Closed ghost closed 6 years ago

ghost commented 6 years ago

Consistency-police found this: gtk peek 2018-04-26 17-30 (blue border on hover (1px?) and stronger blue border when clicked (2px?))

gnome-shell peek 2018-04-26 17-32 (nothing)

Should the gnome-shell-slider get a blue border when hover like in gtk and a thicker blue-border when clicked? Is this even possible?

And this is for @madsrh and @Feichtmeier : could the border around the round slider become orange on hover/click instead of blue? because it is "selected". Tried a mockup and it looks very bad. Maybe you could make a better one when this idea is worth following.

Feichtmeier commented 6 years ago

Yup, tried a lot there - sadly there is no property for neither the border nor the color of the handle (circle) :/ But I would not remove the blue hover on the gtk theme because it looks good on bright backgrounds. I guess we have to live with that

Feichtmeier commented 6 years ago

Maybe @nana-4 or @godlyranchdressing know how this works. Nana managed to change the color atleast on materia screenshot from 2018-04-26 18-06-33

ghost commented 6 years ago

Oh this screenshot fired my desire for white shell-popovers... :heart_eyes:

godlyranchdressing commented 6 years ago

@Feichtmeier there's an unused property I found somewhere in the Shell's source files that should let us change the border color. I'll see if I can find it again.

Well, that was disappointing. Yeah, there's -slider-handle-border-color and it has worked for me before, but it looks like it doesn't anymore. :disappointed:

Feichtmeier commented 6 years ago

@godlyranchdressing yup that was what I've found too but this does not work :disappointed:

Feichtmeier commented 6 years ago

@godlyranchdressing well atleast this works: screenshot from 2018-04-28 01-34-17 If your CSS magic allows some kind of circular box shadow? Other than that the shell is just a bit more flat than the gtk theme so I don't see a big problem here to be honest!

Feichtmeier commented 6 years ago

Not possible currently - closing