search

ubuntu / gnome-shell-communitheme

GNOME Shell Ubuntu community theme "communitheme"
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v2.0
147 stars 19 forks source link

Darken app switchers text color & add a box-shadow to osd-panels #237

Closed Feichtmeier closed 6 years ago

Feichtmeier commented 6 years ago

Closes https://github.com/ubuntu/gtk-communitheme/issues/612

didrocks commented 6 years ago

A new test snap version is available using: snap refresh communitheme --channel=edge/gnome-shell-communitheme-pr237. Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it! You may want to download as well gtk-common-themes snap from edge/gnome-shell-communitheme-pr237 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

Feichtmeier commented 6 years ago

@madsrh just an idea I've noticed that on the corner case "very dark desktop" the app switcher gets lost on the background: peek 2018-07-07 10-35

After adding a shadow: peek 2018-07-07 10-35_bs

really not sure about this though just an idea

madsrh commented 6 years ago

+1 for the shadow (if it looks fine on white/bright backgrounds too)

Feichtmeier commented 6 years ago

Okay another question for you and @clobrano and @godlyranchdressing

How do you feel about adding this shadow to %osd_panel instead and so applying to both the OSDs and the alt tab switchers? If you had a discussion about that already .. I've missed that ;D

screenshot from 2018-07-07 11-50-00 screenshot from 2018-07-07 11-49-51

didrocks commented 6 years ago

A new test snap version is available using: snap refresh communitheme --channel=edge/gnome-shell-communitheme-pr237. Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it! You may want to download as well gtk-common-themes snap from edge/gnome-shell-communitheme-pr237 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

Feichtmeier commented 6 years ago

As Carlo and Mads like it and no-one complained I merge it