search

ubuntu / gnome-shell-extension-appindicator

Adds KStatusNotifierItem support to the Shell
https://extensions.gnome.org/extension/615/appindicator-support/
GNU General Public License v2.0
1.17k stars 159 forks source link

org.kde.StatusNotifierItem property WindowId must be of type "u" instead of "i" #389

Open sfrieske opened 1 year ago

sfrieske commented 1 year ago

The StatusNotifierItem.xml file currently defines the property WindowId as type "i" bust it must be "u" (see freedesktop.org docs).

3v1n0 commented 1 year ago

Oh, that's a good catch... HOWEVER.... The KDE Spec that is what is mostly used so far (at least by qt and friends), had always been using an integer for that.

So I'm not sure what to do here, as I would like not to break that. At the same time, f.d.o. xml spec files seems to be nowhere in gitlab :(

3v1n0 commented 1 year ago

Same is also for qt: https://github.com/qt/qtbase/blob/dev/src/3rdparty/dbus-ifaces/org.kde.StatusNotifierItem.xml and https://github.com/qt/qtbase/blob/c81d5ec19a3bb85a4b8197bd3176dc873c3b7a68/src/gui/platform/unix/dbustray/qstatusnotifieritemadaptor_p.h#L56

Although I don't think they expose it, so maybe there's not a big risk

sfrieske commented 1 year ago

I'm aware that this extension is targeted at running KDE apps on Gnome. And I was afraid that KDE currently 'requires' the different type. May be this is a chance, probably for the KDE team to align this interface with the freedesktop spec. A while ago I read they want to achieve it step by step. My usecase is the iwgtk frontend to iwd that basically shows changing icons for the WLAN RSSI and status (no need of and no use for a menu). Thank you for sharing the code, it was easy enough to adjust it to my needs. If you think there is no good chance to get the type changed feel free to close this issue.

3v1n0 commented 1 year ago

Well, it's true that WindowId is not used by most indicators so probably there's a chance that adjusting this we won't break stuff... mhmh