AppIndicator's NEEDED_PROPERTIES must not unconditionally include 'Menu'

ubuntu / gnome-shell-extension-appindicator

Adds KStatusNotifierItem support to the Shell

https://extensions.gnome.org/extension/615/appindicator-support/

GNU General Public License v2.0

1.14k stars 156 forks source link

AppIndicator's NEEDED_PROPERTIES must not unconditionally include 'Menu' #390

Open sfrieske opened 1 year ago

sfrieske commented 1 year ago

The freedesktop.org docs state that org.freedesktop.StatusNotifierItem.ItemIsMenu can be false. In this case org.freedesktop.StatusNotifierItem.Menu is typically unset. There are a couple of issues about vanished tray icons, another application I encountered is iwgtk. Removing 'Menu' from NEEDED_PROPERTIES fixed it for me.

3v1n0 commented 1 year ago

Well, indeed that's possible, but ideally we'd like not to show icons that are only icons with activation... As these are not really something useful. Reason why menu was always been required.

I see that there could be cases of icons-only around, but not sure how they'd should behave. I'd ideally always just include a menu item with an "Activate" element to perform the actual activation.