ubuntu / handy_window.dart

Provides modern-looking Handy windows with rounded bottom corners for Flutter applications on Linux
https://pub.dev/packages/handy_window
Mozilla Public License 2.0
26 stars 7 forks source link

Wide shadow #26

Closed jpnurmi closed 1 year ago

jpnurmi commented 1 year ago

I've noticed that my screenshots have had super wide shadows lately. Is it coming from here?

image

Feichtmeier commented 1 year ago

I've noticed that my screenshots have had super wide shadows lately. Is it coming from here?

image

I've noticed the same! Good question Does it also happen if you screenshot discord? Since it's made with react native

jpnurmi commented 1 year ago

yaru_widgets example with handy_window removed:

image

jpnurmi commented 1 year ago
Before #22 After #22
image image

/cc @Jupi007

Jupi007 commented 1 year ago

It is "normal" because I copied-pasted the shadow from Libadwaita. But, I just compared nautilus with the handy_window example, and it looks like box-shadow properties are not interpreted in the same way in Gtk3 as in Gtk4... The Libadwaita shadow is bigger than the Gtk3 one, but handy_window one is even larger.

I'll try to adjust that :)

jpnurmi commented 1 year ago

@Jupi007 Did you have time to take a look? I noticed that the wide shadow is included in the minimum window size, too. Unfortunately, GDK includes shadows in the minimum window size. :(

Jupi007 commented 1 year ago

Oh, okay. In fact I had just started to work a little bit on :) But I'll revert it to the original one, I think it is the best thing to do. I didn't know that the shadow was take in account like that.

jpnurmi commented 1 year ago

Me neither. :) I only realized it because the wide shadow made it possible to resize the software store window very small.

jpnurmi commented 1 year ago

Is it possible to revert the shadow only but keep the colors?

Jupi007 commented 1 year ago

What do you mean? Which colors? 🤔

jpnurmi commented 1 year ago

Didn't we change the colors to match libadwaita? Or did I confuse things with the YaruTitleBar colors? :D

Jupi007 commented 1 year ago

Oh, you mean the headerbar (I was searching something colorful 😅). It won't be affected, nor the bright dark theme border :)