Fix Documents, Pictures, Music etc are symlinks in

[lucyllewy]

When a user has one or several XDG_SPECIAL_DIRS folders symlinked in their real home folder to elsewhere in their real home folder common/desktop-exports will attempt to mv those folders to themselves.

• guard mv calls with test for is_subpath to ensure that we're only moving symlinks we created.

While this is not a fatal error here, the electron-builder copies are using bash -e so they fail hard. I will forward these changes to electron-builder once reviewed here... (currently symlinks for Documents etc, combined with the electron-builder default of plugging home, cause electron-builder-built snaps to refuse to launch because the mv calls break the execution due to bash -e.)

Signed-off-by: Daniel Llewellyn diddledan@ubuntu.com

[kenvandine]

This looks sensible. Can you also propose these changes to the snapcraft extensions?

[lucyllewy]

willdo