search

ubuntu / ubuntu-make

Easy setup of common tools for developers on Ubuntu.
GNU General Public License v3.0
1.2k stars 189 forks source link

Duplicate Icon for Visual Studio Code in Ubuntu 17.10 #481

Closed valmar closed 7 years ago

valmar commented 7 years ago

When Visual Studio code is installed and started in Ubuntu 17.10 using the current master branch, an icon is correctly added to Gnome. However, if you pin the icon on the Ubuntu Dock and click on it to start Visual Studio Code, a second icon appears at the bottom of the Dock to manage the open windows of the running application.

The fix is rather easy: the following line should be added to the desktop file generated by ubuntu make

StartupWMClass=Code

LyzardKing commented 7 years ago

Great idea. Do you want to open a pr with this change? If you want to try the method used is get_application_desktop_file, that has a variable extra, where you can copy the additional parts of the desktop file.

valmar commented 7 years ago

I'll try, thanks for the hints!

On Wed, Oct 18, 2017 at 5:47 PM, LyzardKing notifications@github.com wrote:

Great idea. Do you want to open a pr with this change? If you want to try the method used is get_application_desktop_file, that has a variable extra, where you can copy the additional parts of the desktop file.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ubuntu/ubuntu-make/issues/481#issuecomment-337636264, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiFhRvykV9Gluv_lxbx6k5SO4EE1hcTks5sth2NgaJpZM4P9Xdv .

geajack commented 5 years ago

This issue is still happening to me on Ubuntu 18.10. I tracked down the .desktop file in /usr/share/applications (assuming that's the correct one) and it has the line StartupWMClass=Code in it.

Edit: Having posted this, am now having trouble reproducing the bug.

LyzardKing commented 5 years ago

Actually, if you have a .desktop file in /usr/share/applications, it means you installed vscode via apt (or a deb). ubuntu-make holds all the .desktop files in /home//.local/share/applications.