search

ubuntu / ubuntu-make

Easy setup of common tools for developers on Ubuntu.
GNU General Public License v3.0
1.2k stars 189 forks source link

There is no ANDROID_SDK reference anymore #632

Closed lanzorg closed 4 years ago

lanzorg commented 4 years ago

It seems Google changed ANDROID_SDK to ANDROID_SDK_ROOT: https://developer.android.com/studio/command-line/variables#android_sdk_root

It seems using ANDROID_HOME only is enough.

LyzardKing commented 4 years ago

Thanks for the tip @lanzorg Could you test on your system if removing the ANDROID_SDK variable the programs (android sdkmanager, android studio) still work normally?

lanzorg commented 4 years ago

Removing the ANDROID_SDK variable works without any issues with this workaround: https://github.com/ubuntu/ubuntu-make/issues/631#issuecomment-641827149

I can use sdkmanager, avdmanager and so on. I didn't test android-studio though.

LyzardKing commented 4 years ago

But if we leave the variable does it work without the workaround? I'm a bit confused by this change.. I'll test it in the next few days, but every piece of information you're giving me is very helpful.

lanzorg commented 4 years ago

Archlinux users "fixed" this by creating a new package: https://aur.archlinux.org/packages/android-sdk-cmdline-tools-latest/

The old android-sdk package is DEPRECATED: https://developer.android.com/studio/releases/sdk-tools

They don't use the ANDROID_SDK variable too: https://aur.archlinux.org/cgit/aur.git/tree/android-sdk-cmdline-tools-latest.sh?h=android-sdk-cmdline-tools-latest

lanzorg commented 4 years ago

You should remove the deprecated android-sdk and use commandlinetools-linux for umake. https://gist.github.com/ilkerfindik/a009da1fbc63fe0da7454b4098402e28#file-android-sh-L68

LyzardKing commented 4 years ago

Fixed in https://github.com/ubuntu/ubuntu-make/commit/a1b1011a8953f07e23f813d93deafb9c15aa40d6