search

ubuntu / ubuntu-make

Easy setup of common tools for developers on Ubuntu.
GNU General Public License v3.0
1.19k stars 189 forks source link

update godot logo URL #694

Closed Jeffrey04 closed 1 month ago

Jeffrey04 commented 4 months ago

I am seeing some errors while trying to install godot through ubuntu-make saying the logo URL does not exist, so I am submitting this PR. Not sure if this is going to completely fix the problem though. Do let me know if there are other things I need to include as part of the PR.

Jeffrey04 commented 2 months ago

seems to work, but in my test virtualenv i am getting a git error, as shown below

jeffrey04@nobita-ubuntu:ubuntu-make on  update-godot-logo:master [!⇡] via 🐍 v3.12.3 (env) [I]  ./bin/umake games godot
Godot is already installed on your system, do you want to reinstall it anyway? [Yes (y)/No (N)] y
Choose installation path: /home/jeffrey04/.local/share/umake/games/godot
Downloading and installing requirements                                                                                                                                                                                                                                        |
100% |#########################################################################################################################################################################################################################################################################|
Installing Godot
fatal: No names found, cannot describe anything.                                                                                                                                                                                                                               |
|##############################################################################################################################################################################################################################################################################|
Installation done

but otherwise everything seems to work fine, godot is installed, icon is showing up in launcher

LyzardKing commented 2 months ago

Thanks @Jeffrey04 I'll look at the error and merge

Jeffrey04 commented 2 months ago

thanks for the help

LyzardKing commented 1 month ago

I can't reproduce this issue, so I'll merge for now and we can revisit it if it breaks something in the future.