ubuntu / yaru.dart

Ubuntu Yaru Flutter widgets and themes for building desktop and web applications
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
214 stars 35 forks source link

yaru_widgets 2.0 checklist #280

Closed jpnurmi closed 1 year ago

jpnurmi commented 2 years ago

anything else? please add any missing items :)

Jupi007 commented 2 years ago

Maybe add a few tests to check if everything works as expected?

jpnurmi commented 2 years ago

If master-detail has "tiles", what does the compact layout have? How would you call the items that consist of an icon and a text label?

Jupi007 commented 2 years ago

Well, looking at the exact traduction of "tile", imo it would also fit for the navigation rail items. "Item" could also be used btw, but I prefer "tile" :)

jpnurmi commented 2 years ago

I exposed (_)YaruNavigationRailItem without renaming it for now. There's some related naming discussion ongoing at https://github.com/ubuntu/yaru_widgets.dart/pull/284#issuecomment-1275772841.

Feichtmeier commented 2 years ago

Looks good! Regarding "widgets everywhere"

277 would be cool to fix, any takers? 🙈

jpnurmi commented 2 years ago

Can someone help create master-detail and navi-rail wireframes? Perhaps something similar to the dock mode etc. in the settings app?

Jupi007 commented 2 years ago

@Muqtxdir as you did "settings" dock mode images, maybe you could be interested by doing the wireframes?

Muqtxdir commented 2 years ago

hi everyone 👋

by wireframes do you mean recolorable SVG(s)?

jpnurmi commented 2 years ago

hi! :) the idea is to explain the two layouts / navigation patterns in the docs

image

Muqtxdir commented 2 years ago

ah thanks for the explanation @jpnurmi. could you share some actual screenshots as well, I'll use that as reference for wireframes

jpnurmi commented 2 years ago

Awesome, thank you! The software and settings apps are great examples even though the content on the right side could be anything. yaru_widgets offer generic building blocks to easily create apps with either of these layouts.

navi-rail (software) master-detail (settings)
image image
Jupi007 commented 2 years ago

The software screenshot isn't exactly representative of the current navigation rail look :) @Muqtxdir if you can, run the example app of this repository. You will be able to switch between layout with a switch on the first page.

Muqtxdir commented 2 years ago

ok,noted. thanks everyone.ill look into this one once i reach home

Feichtmeier commented 1 year ago

Adding to the wishlist:

It's almost christmas! 🌴 🎄 🎅

jpnurmi commented 1 year ago

Are we in good enough shape to publish a pre-release e.g. 2.0.0-beta.1?

Jupi007 commented 1 year ago

I'm working on the checkboxes, if we can add them in beta.2, I want to say yes.

whiskeyPeak commented 1 year ago

I looked at the current yaru widget selection and there doesn't seem to be a yaru themed textfield widget. It'd be nice if it could make itself into the 2.0 release. I can open an adjacent issue to further discuss the design language if it is something that needs to be implemented :)

@jpnurmi

Feichtmeier commented 1 year ago

Well ideally we should be able to do this with yaru.dart, I hope. I try tomorrow. If not... we need our own :S

Jupi007 commented 1 year ago

What's the problem with the current material text entries? 🤔

Feichtmeier commented 1 year ago

too thick border

Jupi007 commented 1 year ago

Oh, okay. Well yes, this should be fixed in the theme so 🙂

whiskeyPeak commented 1 year ago

Well ideally we should be able to do this with yaru.dart, I hope. I try tomorrow. If not... we need our own :S

Ah oops, didn't see that package. O_O

jpnurmi commented 1 year ago

Any takers for unifying the borders? Or do we even need it for 2.0 because it's probably not going to be a breaking change because it won't affect the API?

Jupi007 commented 1 year ago

What do you exactly mean with unify? Unify the borders color?

jpnurmi commented 1 year ago

Hmm, I wish I had included a link to the discussion wherever it was... I think around the time when YaruBorderContainer was added.

But basically yeah, there are quite a few different variants of colorScheme.onSurface.withOpacity(0.x) with slightly different opacity levels being used as border and divider colors across yaru.dart and yaru_widgets.dart. The idea was to unify them and make use of ThemeData.dividerColor and DividerTheme.color where possible.

Feichtmeier commented 1 year ago

divider color should be fine for all. if we want it to be lighter, we should change this in yaru.dart

Jupi007 commented 1 year ago

divider color should be fine for all. if we want it to be lighter, we should change this in yaru.dart

I agree 👍

jpnurmi commented 1 year ago

Here's the earlier discussion I was referring to: https://github.com/ubuntu/yaru_widgets.dart/pull/333

Feichtmeier commented 1 year ago

Looking at the list I don't think any critical things are left to release 2.0.0 :) I can update Settings later What about the firmware-updater? :)

jpnurmi commented 1 year ago

I'm also happy with how things are. :+1: Docs and stuff can be improved later. :)

Feichtmeier commented 1 year ago

I'm also happy with how things are. :+1: Docs and stuff can be improved later. :)

😎 Ok Can you do it? I think it's your honour since you pimped this repo up from the ground 🚀

jpnurmi commented 1 year ago