Closed jpnurmi closed 1 year ago
Maybe add a few tests to check if everything works as expected?
If master-detail has "tiles", what does the compact layout have? How would you call the items that consist of an icon and a text label?
Well, looking at the exact traduction of "tile", imo it would also fit for the navigation rail items. "Item" could also be used btw, but I prefer "tile" :)
I exposed (_)YaruNavigationRailItem
without renaming it for now. There's some related naming discussion ongoing at https://github.com/ubuntu/yaru_widgets.dart/pull/284#issuecomment-1275772841.
Looks good! Regarding "widgets everywhere"
Can someone help create master-detail and navi-rail wireframes? Perhaps something similar to the dock mode etc. in the settings app?
@Muqtxdir as you did "settings" dock mode images, maybe you could be interested by doing the wireframes?
hi everyone 👋
by wireframes do you mean recolorable SVG(s)?
hi! :) the idea is to explain the two layouts / navigation patterns in the docs
ah thanks for the explanation @jpnurmi. could you share some actual screenshots as well, I'll use that as reference for wireframes
The software screenshot isn't exactly representative of the current navigation rail look :) @Muqtxdir if you can, run the example app of this repository. You will be able to switch between layout with a switch on the first page.
ok,noted. thanks everyone.ill look into this one once i reach home
Adding to the wishlist:
It's almost christmas! 🌴 🎄 🎅
Are we in good enough shape to publish a pre-release e.g. 2.0.0-beta.1?
I'm working on the checkboxes, if we can add them in beta.2, I want to say yes.
I looked at the current yaru widget selection and there doesn't seem to be a yaru themed textfield widget. It'd be nice if it could make itself into the 2.0 release. I can open an adjacent issue to further discuss the design language if it is something that needs to be implemented :)
@jpnurmi
Well ideally we should be able to do this with yaru.dart, I hope. I try tomorrow. If not... we need our own :S
What's the problem with the current material text entries? 🤔
too thick border
Oh, okay. Well yes, this should be fixed in the theme so 🙂
Well ideally we should be able to do this with yaru.dart, I hope. I try tomorrow. If not... we need our own :S
Ah oops, didn't see that package. O_O
Any takers for unifying the borders? Or do we even need it for 2.0 because it's probably not going to be a breaking change because it won't affect the API?
What do you exactly mean with unify? Unify the borders color?
Hmm, I wish I had included a link to the discussion wherever it was... I think around the time when YaruBorderContainer
was added.
But basically yeah, there are quite a few different variants of colorScheme.onSurface.withOpacity(0.x)
with slightly different opacity levels being used as border and divider colors across yaru.dart
and yaru_widgets.dart
. The idea was to unify them and make use of ThemeData.dividerColor
and DividerTheme.color
where possible.
divider color should be fine for all. if we want it to be lighter, we should change this in yaru.dart
divider color should be fine for all. if we want it to be lighter, we should change this in yaru.dart
I agree 👍
Here's the earlier discussion I was referring to: https://github.com/ubuntu/yaru_widgets.dart/pull/333
Looking at the list I don't think any critical things are left to release 2.0.0 :) I can update Settings later What about the firmware-updater? :)
I'm also happy with how things are. :+1: Docs and stuff can be improved later. :)
I'm also happy with how things are. :+1: Docs and stuff can be improved later. :)
😎 Ok Can you do it? I think it's your honour since you pimped this repo up from the ground 🚀
unify borders#588add missing brief class descriptions#587anything else? please add any missing items :)