ubuntu / yaru.dart

Ubuntu Yaru Flutter widgets and themes for building desktop and web applications
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
214 stars 35 forks source link

Rename `YaruCompactLayout`? #416

Closed jpnurmi closed 1 year ago

jpnurmi commented 1 year ago

While we still have a chance to land breaking changes before 2.0, it would be nice if YaruCompactLayout had a name that:

_Originally posted by @jpnurmi in https://github.com/ubuntu/yaru_widgets.dart/issues/414#issuecomment-1326684850_

I wish YaruCompactLayout would be named something like YaruNavigationPage to be consistent with YaruMasterDetailPage and YaruNavigationRail but it would break the software app once again... :thinking:

_Originally posted by @jpnurmi in https://github.com/ubuntu/yaru_widgets.dart/issues/284#issuecomment-1275801935_

  • YaruNavigationPage
  • YaruNavigation(Page)Theme
  • YaruNavigationRail
  • YaruNavigation(Rail)Item
  • YaruNavigationBar
  • ...?
Jupi007 commented 1 year ago

Personally, I think that YaruNavigationPage sounds good. But what is the problem with the software app?

jpnurmi commented 1 year ago

I didn't buy my own proposal earlier because it didn't feel like a big enough improvement to justify the break. I decided to bring it up again now that we have YaruPageController in the pipeline.

Also, I'm starting to feel embarrassed for breaking all the apps again and again but if Frederik says it's ok... :see_no_evil: