Closed Feichtmeier closed 7 months ago
important note to us when you run the golden tests from windows, all are changed to windows ^^ but this is a rare case I hope
@Jupi007 could you check if I made any mistake on your UBuntu machine?
Oh okay, well can you add a golden variant for the title bar test so we can test both yaru/windows?
you mean I should commit the test changes? dont they overwrite anything?=
No no, I didn't mean to commit and overwrite the yaru images with windows ones, but to add a windows golden variants to append the windows variant to the yaru images 🙂
I just tested your branch on Ubuntu and I can't notice any problem.
As you can see here, I added both variants to the test suit: https://github.com/ubuntu/yaru_widgets.dart/blob/5a05b25e0797cd765e2c9589766486c3eb8201f8/test/widgets/yaru_window_control_test.dart#L89
No no, I didn't mean to commit and overwrite the yaru images with windows ones, but to add a windows golden variants to append the windows variant to the yaru images 🙂
I just tested your branch on Ubuntu and I can't notice any problem.
As you can see here, I added both variants to the test suit:
oh no. how would I do this? :D where?
Here:
You can do something similar as I did here:
Or if you want, I can do it in a separate PR 🙂
Yes please do it