search

ubuntu / yaru.dart

Ubuntu Yaru Flutter widgets and themes for building desktop and web applications
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
179 stars 33 forks source link

Material Components: Golden tests #848

Open jpnurmi opened 1 year ago

jpnurmi commented 1 year ago

Perhaps we could have a simple golden test that takes screenshots of all pages in the example with the different variants? It's somewhat tedious and error-prone to manually browse the example back and forth with several themes. :)

jpnurmi commented 1 year ago

Intentional theme changes would need to be coupled with flutter test --update-goldens and it would slowly increase the repo size but at least we'd have a better overview of how PRs affect various theme variants and modes... what do you say?

Feichtmeier commented 4 months ago

@Jupi007 couldnts we eventually copy those tests from flutter/flutter for the pure material widgets?

Jupi007 commented 4 months ago

@Feichtmeier This will be very heavy to maintain, isn't it? I think the original JP's idea is better. Btw his code is already working, why didn't he make a PR?

Feichtmeier commented 4 months ago

@Feichtmeier This will be very heavy to maintain, isn't it? I think the original JP's idea is better. Btw his code is already working, why didn't he make a PR?

I have no idea. Maybe it wasn't finished

Feichtmeier commented 4 months ago

Here is JPs work for future work on this https://github.com/ubuntu/archive_yaru.dart/pull/320/files