search

ubuntu / yaru.dart

Ubuntu Yaru Flutter widgets and themes for building desktop and web applications
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
179 stars 33 forks source link

fix(IconButton): selected color needs to be different to onSurface #869

Closed Feichtmeier closed 3 months ago

Feichtmeier commented 3 months ago

Fixes #862

This slightly increases also the contrast of the icon colors everywhere, IMO this is a good change, WDYT @Jupi007 ?

Jupi007 commented 3 months ago

Can you post a screenshot before/after, please? 🙏 I'm currenly not at home, and looking at the golden diff is impossible with the github app.

Feichtmeier commented 3 months ago

sure, sorry. here you go @Jupi007

Before:

https://github.com/ubuntu/yaru.dart/assets/15329494/a8394b9a-67e0-4ee6-8944-7b42bbb3f05f

After:

https://github.com/ubuntu/yaru.dart/assets/15329494/ccd593d4-e1d1-48f6-ab4e-309b18e34673