ubuntu / yaru.dart

Ubuntu Yaru Flutter widgets and themes for building desktop and web applications
https://ubuntu.github.io/yaru.dart/
Mozilla Public License 2.0
199 stars 35 forks source link

feat: follow accent-color gsettings key for 24.10 #922

Closed Feichtmeier closed 1 week ago

Feichtmeier commented 2 weeks ago

Okay this turned out to be a bit more complicated, just listening for gtk-theme-name is not enough anymore.

For the flutter people:

For the gnomers (i.e. marco :P @3v1n0 ):

24.10:

https://github.com/user-attachments/assets/bed8a8cd-8f1b-435a-8ddf-c0f31212b728

24.04:

https://github.com/user-attachments/assets/4bdda218-4e18-4140-b652-092d9f52bbbc

3v1n0 commented 2 weeks ago

Logic seems fine, not sure on code itself :)

However, in theory applications could even just rely on dbus, using the portal value, but that would require some color translation that it's not very easy without relying on Adw itself.

Feichtmeier commented 2 weeks ago

Logic seems fine, not sure on code itself :)

However, in theory applications could even just rely on dbus, using the portal value, but that would require some color translation that it's not very easy without relying on Adw itself.

yes we can create new flutter themes on the fly with any given primary color but currently a portal service is out of scope for me so maybe for after 24.10?