ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

insert-text and edit-select-all are hard to distinguish #1073

Closed Feichtmeier closed 5 years ago

Feichtmeier commented 5 years ago

image

image

image

@ubuntujaggers could you take a look at edit-select-all ? I think adwaita got it a bit more right, maybe we can just copy this one and make it thinner? Or just copy it I don't know image https://gitlab.gnome.org/GNOME/adwaita-icon-theme/blob/master/src/symbolic/gnome-stencils.svg

ubuntujaggers commented 5 years ago

I started off trying to clone the Adwaita one with a squircle boundary instead of a hard square. 16x16px is an even number which doesn't lend itself well to central dividers (there are two in the Adwaita design) because it means they have to be 2px wide (which looks too big), or not quite central.

Looking at Adwaita, they've got round this by making the whole icon slightly off-centre, which I didn't know was allowed. So the icon is 16x16px but the actual graphic fills 13x13px (the following shows the graphic relative to the icon boundary):

image

Before I realised what Adwaita was doing I tried a different glyph to represent "everything" that didn't use central divisions:

image

image

I actually quite like this, because having a stack of two things to represent "all" resembles other action icons like copy, paste, open. However, is it intuitive (well - at least as intuitive as the Adwaita icon)?

So, two options;

I tried a third option ("Copy Adwaita and have 2px central divisions") but it didn't look good at all IMO. I will do some mockups of the other two options.

Feichtmeier commented 5 years ago

Nice! I'd prefer your glyph :)

ubuntujaggers commented 5 years ago

Ah, super - I've also done the Adwaita approach so here it is for comparison:

image

image

Feichtmeier commented 5 years ago

This looks also nice :) you decide and/or @madsrh @clobrano