search

ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

Missing 2048 icon #1124

Closed eaglersdeveloper closed 5 years ago

eaglersdeveloper commented 5 years ago

What about this icon?

2048

Feichtmeier commented 5 years ago

Why not! Is it installed with a snap on Ubuntu? If yes you/one need (s) to check if the snap uses a hard path to the icon location in its desktop file to make this icon work

Offtopic but: @eaglersdeveloper could you check your notification board on GitHub and answer at least on the PRs you've opened?

jbicha commented 5 years ago

There isn't a a Snap yet, but I might make one.

@kenvandine Why does quadrapassel hard-code the icon path but gnome-calculator doesn't?

kenvandine commented 5 years ago

gnome-calculator is using the themed icon. We've gone back and forth. The themed icons tend to not work well across different distros and versions. Setting the path to the shipped icon is more reliable across distros but then doesn't honor the theme.

On Sun, Jan 27, 2019, 5:58 PM Jeremy Bicha <notifications@github.com wrote:

There isn't a a Snap yet, but I might make one.

@kenvandine https://github.com/kenvandine Why does quadrapassel https://bazaar.launchpad.net/~ubuntu-desktop/quadrapassel/snap/view/head:/snapcraft.yaml hard-code the icon path but gnome-calculator https://bazaar.launchpad.net/~ubuntu-desktop/gnome-calculator/snap/view/head:/snapcraft.yaml doesn't?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/1124#issuecomment-457962371, or mute the thread https://github.com/notifications/unsubscribe-auth/AADWBQahM2uKY2kYwDZ0D80lTogNi7FDks5vHi8EgaJpZM4aFOqk .

jbicha commented 5 years ago

The proposed new upstream gnome-2048 icon is interesting too.

If you click View File next to data/icons/org.gnome.TwentyFortyEight.svg at https://gitlab.gnome.org/GNOME/gnome-2048/merge_requests/5/diffs , it's easy to see a preview.

Feichtmeier commented 5 years ago

Currently this whole topic is being discussed. If we end up with moving away from the uniform squircle baseplate this Suru icon will not be needed. Same for inkscape, Firefox and so on

Let's keep it opened for a while since nothing is set in stone yet but it looks like we move away from providing Suru icons for non-core apps

Feichtmeier commented 5 years ago

Closing this since the recent direction of out icon theme :) Current progress can be seen here: https://github.com/ubuntu/yaru/issues/1180 and here: https://github.com/ubuntu/yaru/pull/1209