ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

Suggestion: Login screen password box #1342

Closed stuarthayhurst closed 5 years ago

stuarthayhurst commented 5 years ago

The white in the password box and cancel button doesn't really fit with the rest of the login screen or the topbar, the dark box as seen in Ubuntu 18.04 without Yaru fits MUCH better.

Current: alt text

Dark boxes, like 18.04: alt text

clobrano commented 5 years ago

Hi @Dragon8oy, it is an interesting idea, we will try, thanks!

clobrano commented 5 years ago

So, before making any PR, I'll present some mockups here.

First is simply the default dark entry in our shell

image

There are some observation from my side

Mainly for the second point, I tested also a purple selection (that will be used only for this specific context)
image

This way it makes a bit more sense, but it's not a clear win over the current login for me.

What do you think?

stuarthayhurst commented 5 years ago

That's exactly what I meant, to me it looks way better than what's currently in Yaru.

Feichtmeier commented 5 years ago

I think the whole composition is a bit chaotic now. I would suggest to make the button also dark Also increasing the brightness of the purple is a must then, since the contrast is really poor

Feichtmeier commented 5 years ago

Some ideas, first inkstone background, transparent black entry, red destructive button (seen on telegram) image image which has a very good contrast but could look a bit "boring"

Same bg color but with the noise texture from upstream image

Not-so-super-dark purple with the noise texture image

Same bg, dark gray button image

stuarthayhurst commented 5 years ago

Definitely one of the purple backgrounds, I think I prefer the red button as then it's like green and read to unlock and cancel, like launch and abort buttons, etc. Either is better than the white Cancel button though

clobrano commented 5 years ago

I'm not convinced by the red button, it's not a destructive action

stuarthayhurst commented 5 years ago

I think the red works well because it contrasts well with the green and you often see green and red having opposite actions (Stop, Go - Cancel, Continue).

May I ask what happened to the Ubuntu logo at the bottom of the purple images?

Feichtmeier commented 5 years ago

I like the bright red just for the lolz But I agree it makes not so much sense, because the user's eye jumps back and forth between Succeed! Destroy! Succeed! Destroy! :)

May I ask what happened to the Ubuntu logo at the bottom of the purple images?

Nothing, I just showed the lock screen and not the log in screen. It is there, no panic

stuarthayhurst commented 5 years ago

Ok, whatever you guys want. I was just suggesting that the password box and cancel button be styled to fit, which has been achieved. Whatever comes from here, I probably don't mind.

Paz-it commented 5 years ago

+1 for @Feichtmeier last mock-up with the dark Gray button

Feichtmeier commented 5 years ago

Hmmm i am still not convinced that these are better than the current one though the current one is far from perfect Let's see if we can come up with something else, also would be nice if we could wait until @madsrh is back in town

madsrh commented 5 years ago

Same bg, dark gray button

I think this is the best one, but...

Hmmm i am still not convinced that these are better than the current one though

+1 The current is great for accessibility ♿️

There's an old issue where @godlyranchdressing did some mockups and I believe the red button is a no-go because it isn't a destructive action.

clobrano commented 5 years ago

+1 The current is great for accessibility

this is an important observation. If we're not convinced this is a real improvement, I'd say let's keep the current state

Feichtmeier commented 5 years ago

We could keep the level of usability/accessibility if we carefully set the contrast of the elements with the dark login screen.

Contrast between popups/BG Entry/BG Button/BG Focus border / button Focus border / entry

Feichtmeier commented 5 years ago

What about this @clobrano @madsrh @ubuntujaggers

Screenshot from 2019-05-08 17-52-27

Screenshot from 2019-05-08 17-52-52

This might also be too dark...

Or this: Screenshot from 2019-05-08 17-56-18

clobrano commented 5 years ago

Updated #1348 with brighter background. I have a problem with the VM so I cannot provide a screenshot right now, I'll try again later

Feichtmeier commented 5 years ago

Yes I tried your branch. Why did you change the focus colour to be inkstone? :D

clobrano commented 5 years ago

It looks way better than purple for me

Feichtmeier commented 5 years ago

I meant the focus color, not normal border color :) https://github.com/ubuntu/yaru/pull/1348/commits/e9e05a9473b14fa58351462b7a6fc4823a10da52#diff-bd1d59deea6a6eeba80285784fae338bR1975

Also the button is not equally flat anymore this way. It would be better if you would adapt the mixin I think And the purple is still a bit too dark imho, the contrast is not high enough. Currently in master it is basically too high, because the dark purple looks almost black with the white entry and button It's not easy, maybe we should stay in this thread and find a good solution by providing screenshots before rushing anything

clobrano commented 5 years ago

Ah, I don't know, I didn't on purpose and I wasn't able to change it

On Wed, 8 May 2019, 20:47 Feichtmeier, notifications@github.com wrote:

I meant the focus color, not normal border color :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/1342#issuecomment-490605192, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWAAHSIV2HTCPL6P7KOQWDPUMN4BANCNFSM4HK7TXZQ .

clobrano commented 5 years ago

I meant the focus color, not normal border color :) e9e05a9#diff-bd1d59deea6a6eeba80285784fae338bR1975

basically because in "focus" state $fc is used only for the border

And the purple is still a bit too dark imho, the contrast is not high enough.

ok

clobrano commented 5 years ago

Slightly brighter purple and cancel button

image

clobrano commented 5 years ago

Also, I find the default user-icon a bit lost in space, what about this instead?

Screenshot from 2019-05-09 15-39-11

here with a non-default icon Screenshot from 2019-05-09 15-39-47

Feichtmeier commented 5 years ago

The contrast should be high enough now I have no strong opinion on the circle But I think the colour combinations could be harmonized a little. Gray button, black entry, white circle. It looks a tiny bit unorganized now. Let's wait for the others or make more suggestions

basically because in "focus" state $fc is used only for the border

Yes, but why don't we leave the focus border orange like with all other entries?

Edit: I think the colours are fine, maybe only some time to get used to it is needed

clobrano commented 5 years ago

Yes, but why don't we leave the focus border orange like with all other entries?

Because I think that a thin orange line in a wide purple background does not fit very well, and the example of 18.04 without the orange border looks good, but it might be just my opinion.

EDIT: brighter close button might be needed, or it would look smaller than the green one due to the purple background

Feichtmeier commented 5 years ago

Could you show a picture with the button as dark as the entry?

Edit: I think the cancel button is not fully flat. We might need the changes in drawing I did in my branch, because what we basically do in common, in popovers and dialogues, is to flatten everything manually. So the regular button styling from drawing is used nowhere :D

clobrano commented 5 years ago

Cancel button is fully flat, there's no box-shadow, just a slightly brighter (1%) border that can eventually be removed.

Here is the cancel button in inkstone, but IMO it is too similar to the entry

image

Feichtmeier commented 5 years ago

Okay that looks bad, nvm.

Yeah the border. Fine, then let's finish the styling and I'll do a little code refactoring without a style change after we finished this here

clobrano commented 5 years ago

What kind of refactoring you have in mind?

Feichtmeier commented 5 years ago

https://github.com/ubuntu/yaru/commit/08fe505124e557d902576fb631da5cda1fc15f75

Like this. (The drawing file part of the commit)

Feichtmeier commented 5 years ago

Hm, i am still not sure about this. Tried your branch and I don't really like the colour combinations :( It's also yet another styling Currently we have the dark translucent style and the solid white style across the shell This introduces a third even more mixed styling

clobrano commented 5 years ago

We can even keep the same white entry and cancel button we have now, but now that I worked more on it, I would still ship the white circle and the focus border change

Feichtmeier commented 5 years ago

Thought about further reducing the amount of colors. What about this @madsrh @clobrano @ubuntujaggers :

Screenshot from 2019-05-10 15-00-48

(circle around the avatar is excluded just because I am very neutral on that :) )

madsrh commented 5 years ago

I like the slightly transparent entry, but I'm not sure about the purple cancel button - it looks good but will it be confusing?

Are you both +1 for the noise bg? I'm asking for a friend ;)

Feichtmeier commented 5 years ago

Lol! xD Who is that friend? NusiNusi? :O I like the noise bg, and I have no idea why I did not like it back then. It reduces the "terror of the purple" a bit.

clobrano commented 5 years ago

Are you both +1 for the noise bg? I'm asking for a friend ;)

I've always been :D, but not as much to fight for it

stuarthayhurst commented 5 years ago

I think the dark grey cancel worked better, shows 18.04 and works with the password box better.

meetdilip commented 5 years ago

Why not use a wallpaper ? I used to have one after editing Ubunut.css . I looked great.

Feichtmeier commented 5 years ago

Because wallpapers can be strechtched by different resolutions or float around not centered. That texture is one solution that works on every screen

ubuntujaggers commented 5 years ago

Sorry I've been busy lately! I never liked the noise much but happy to be outvoted, it's not like it'll bother me :)

ubuntujaggers commented 5 years ago

I like those colours btw. Edit: and prefer no circle.

meetdilip commented 5 years ago

Isn't circle for user avatar the trend these days ?

clobrano commented 5 years ago

White border was in previous version, but the shape was a squircle. When upstream moved to rounded avatars we tried for a bit and then drop it because the border was too close to the default user icon. Now I tried to add some space and IMO it doesn't look bad. I prefer how it looks with the avatar pic, but without it the default user icon seems drop in the middle of nowhere

Feichtmeier commented 5 years ago

@clobrano tbh you are right, purple and orange does not look perfect. How about white as the border color for the whole login screen?

image image

Or slightly transparent white image image

Or more transparentized white image image

clobrano commented 5 years ago

The last one is better and looks good

stuarthayhurst commented 5 years ago

What about with the cancel as some shade of grey? I feel it might look better but if not, that seems good.

Feichtmeier commented 5 years ago

@Dragon8oy it is very subjective at this point, but the gray, black, purple combination were kind busy in terms of amount of colors

WHat about the user selection @clobrano ? That is also orange on purple Maybe this works instead ?

image image

Edit: but I think @clobrano is right, something has to be done with the circle, since other users first letter is put into a circle shape

Edit2: what about this: image image

clobrano commented 5 years ago

I am not in favor of the purple for selection, even more if combined with the color of the cancel button (someone could think that both widgets are selected)

stuarthayhurst commented 5 years ago

Yeah same, I don't think the purple button works on the purple background very well, it's too much of the same colour IMO.