Add support for qt5ct with qt5-gtk-platformtheme

lwbt commented 5 years ago

Expected Behavior

QT5 apps like KeepassXC and VLC should render in GTK3 Yaru style instead of Adwaita.

I did some research and found threads where qt5ct with qt5-gtk-platformtheme is recommended: https://github.com/keepassxreboot/keepassxc/issues/1931

Actual Behavior

Only Adwaita is offered in the selection.

Steps to Reproduce the Problem

apt install qt5ct qt5-gtk-platformtheme
run and configure qt5ct, for example to use a dark theme variant
run example app with QT_QPA_PLATFORMTHEME="qt5ct" vlc or put it in your .profile file

Specifications

I'm running yaru as it is shipped with 19.04.

Software that presents the issue:

$ apt-cache policy vlc keepassxc qt5ct qt5-gtk-platformtheme yaru-theme-gnome-shell 
vlc:
  Installed: 3.0.6-1
  Candidate: 3.0.6-1
  Version table:
 *** 3.0.6-1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
keepassxc:
  Installed: 2.3.4+dfsg.1-1
  Candidate: 2.3.4+dfsg.1-1
  Version table:
 *** 2.3.4+dfsg.1-1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
qt5ct:
  Installed: 0.37-1build1
  Candidate: 0.37-1build1
  Version table:
 *** 0.37-1build1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
qt5-gtk-platformtheme:
  Installed: 5.12.2+dfsg-4ubuntu1
  Candidate: 5.12.2+dfsg-4ubuntu1
  Version table:
 *** 5.12.2+dfsg-4ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu disco/universe amd64 Packages
        100 /var/lib/dpkg/status
yaru-theme-gnome-shell:
  Installed: 19.04.2
  Candidate: 19.04.2
  Version table:
 *** 19.04.2 500
        500 http://archive.ubuntu.com/ubuntu disco/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu disco/main i386 Packages
        100 /var/lib/dpkg/status

clobrano commented 5 years ago

Hi @lwbt, thank you for taking time to report this and for the research, awesome! I wonder how we can add yaru to the list, we might need to reach the maintainers of the project and ask them

Paz-it commented 5 years ago

Hi @lwbt -From your description it looks like you installed only Yaru-shell theme, correct me if I'm wrong. IF I'm right you have to install the Gtk part of it that include Gtk3+Gtk2 as well. When you do : Try to choose Gtk2 in the menu and run your example line like this : QT_QPA_PLATFORMTHEME="gtk2" vlc Is it working for you that way?

clobrano commented 5 years ago

Yaru is installed by default in 19.04, no need to install other pieces manually

On Sun, 12 May 2019, 23:47 Paz-it, notifications@github.com wrote:

Hi @lwbt https://github.com/lwbt -From your description it looks like you installed only Yaru-shell theme, correct me if I'm wrong. IF I'm right you have to install the Gtk part of it that include Gtk3+Gtk2 as well. When you do : Try to choose Gtk2 in the menu and run your example line like this : QT_QPA_PLATFORMTHEME="gtk2" vlc Is it working for you that way?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/1357#issuecomment-491632087, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWAAHXVHLMWI2CBKB3LS4DPVCGALANCNFSM4HMKRKGQ .

Paz-it commented 5 years ago

Yaru is installed by default in 19.04, no need to install other pieces manually

That's correct @clobrano , Sorry! I'm still on 18.04 LTS . But all the rest should work as far as I understand.

Feichtmeier commented 5 years ago

Opened the zip.. isn't this the same as https://github.com/ubuntu/yaru/issues/1294 ?

lwbt commented 5 years ago

I don't see any relation.

Feichtmeier commented 5 years ago

Nvm, I should stay away from GitHub before 10:00 xD

CDrummond commented 5 years ago

The Qt5 configuration tool will only show Qt themes. There is an Adwaita Qt theme, which provides Adwaita and Adwiata-Dark for Qt apps - which is why these appear in the list. For Yaru to appear in this list, there would need to be a pure Qt version of Yaru.

I seem to recall that Adwaita-Qt is GPL licenses, as is Kvantum, so not sure Ubuntu can install that - for the same reasons it cannot use Kvantum.

ubuntu / yaru