ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.36k stars 182 forks source link

Selecting folders makes emblems indistinguishable #1395

Closed memeplex closed 5 years ago

memeplex commented 5 years ago

Expected Behavior

Distinctive folder emblems shouldn't be obfuscated by the theme, specially for folders selected for action.

Actual Behavior

It's very difficult to spot the emblem of selected folders. I've tested this using both Yaru and Papirus icon sets.

image

Steps to Reproduce the Problem

  1. Open Nautilus
  2. Go to you Home directory
  3. Select a couple of special xdg folders there

Specifications

memeplex commented 5 years ago

As a more general observation I would say that the color is too dark orange and plays really bad with non-orange icons (for example, default Papirus folders are blue and selected folders look more like "disabled" folders). By highlighting the text of selected folders but leaving the icon alone (or slightly modifying the color) you will both make emblems visible and better behave with other icon sets.

Feichtmeier commented 5 years ago

We could insert more app styling for nautilus or rather ask on the gitlab repo for a change. I did so some months ago and it's still opened. Cant find the look to the issue right now but I'll attach it here when I find it

memeplex commented 5 years ago

I see @Feichtmeier . Still, don't you think lowering a bit the "oranginess" of the selection would improve contrast and also make things look better, consider this:

image

I like the personality of Yaru but I find this too much, don't you?

Feichtmeier commented 5 years ago

We modified nautilus in bionic to only the label is selected. That's not possible anymore since cosmic sadly.

Feichtmeier commented 5 years ago

grafik That's bionic - nice isn't it? Sadly we did not manage to reproduce this fix for cosmic and disco So I opened this issue: https://gitlab.gnome.org/GNOME/nautilus/issues/786 Imho we should not spend more energy on this, it should be fixed by nautilus @madsrh @clobrano feel free to re-open if you disagree