search

ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

Third party app: To squircle or not to squircle? #1564

Closed ztefn closed 5 years ago

ztefn commented 5 years ago

Hi there! I'm in need of a little bit advise.

As @eaglersdeveloper pointed out on Twitter a while ago, Haguichi was the first third party app to ship an Suru/Yaru style icon for Ubuntu. Everything was fine back then.

However, starting Ubuntu 19.04 the Yaru icons have shifted style from squircle to more square. So while the icon I'm shipping looks perfect on Ubuntu 18.04, it looks a little bit off on Ubuntu 19.04 and 19.10 (and 20.04 LTS in 6 months).

So, this left me wandering which road I should take:

  1. Keep the Suru squirle style (and be out of place on every Ubuntu version later than 18.04).
  2. Update the icon to a more square style (and be out of place only on Ubuntu 18.04).
  3. Stop shipping the Suru/Yaru style icons completely and thus have Ubuntu use the standard GNOME style icon.
  4. Some other option I haven't thought about?

Although it's a waste of effort I'm tending towards option 3 myself. Option 2 might also work if someone from the Yaru team is willing to update the icon.

What do you guys think?

clobrano commented 5 years ago

Hi @ztefn,

I believe there's a little misunderstanding. The icon style on 18.04 is the same as in 19.04 and following, this is basically because we already dropped the squircle style, so if you update to the new Yaru icons, it will fit perfectly in 18.04 as well

About option 2 let's summon @ubuntujaggers to see what he thinks :)

Feichtmeier commented 5 years ago

But only in the edge channel, right?

clobrano commented 5 years ago

Did we switch icon set only on edge? Okay, this is a problem, but it's going to be released soon, together with Eoan

On Mon, 7 Oct 2019 at 14:06, Feichtmeier notifications@github.com wrote:

But only in the edge channel, right?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/1564?email_source=notifications&email_token=AAWAAHQQPXJJYTTBYDDAFEDQNMQ3FA5CNFSM4I6DQAX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQCKUI#issuecomment-538977617, or mute the thread https://github.com/notifications/unsubscribe-auth/AAWAAHVZPBVAUM4UCBITIELQNMQ3FANCNFSM4I6DQAXQ .

ubuntujaggers commented 5 years ago

Lovely icon! I'm more than happy to update it.

ztefn commented 5 years ago

Cool! You're welcome to fork Haguichi master branch and open a pull request any time you want.

Also, if you have any questions don't hesitate to ask!

clobrano commented 5 years ago

Very well! Since the work will be done on Haguichi repo, I can close this here. Feel free to reopen it if you think it's necessary. Thanks!