ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

Proposal: filemanager icon #1755

Closed Feichtmeier closed 4 years ago

Feichtmeier commented 4 years ago

I think I did not make a secret out of my opinion on the blue file cabinet icon image

I really think it does not fit into that whole origami style of all the other nice icons you've made @ubuntujaggers

I spoilered the idea on telegram but here - for the "rest" - this is the idea:

image

Basically the "old" / Suru icon but on one of the new Yaru baseplates. I am not sure about the brown though, but it's prbly a safe pick.

Or a white one: image

Or... insert any other baseplate color here

Opinions, onions and whatnot? @madsrh @ubuntujaggers @clobrano ?

Just for the history on why we changed it: we completely removed the baseplate back then and it was only a single white folder as an icon - then someone complained (and this was a correct complain) that it would only represent a directory and not a file manager)

clobrano commented 4 years ago

All the "complains" still hold for me:

I am okay with both really, my only note is to take one and be consistent, better not going back and forth every other release :)

Feichtmeier commented 4 years ago

Or make the current one look more like the rest of the icons :man_shrugging: Most of them only have 1 or 2 basic symbols on them. Very simple. I think the current one is too much. Too many highlights too many elements (3 handles 3 drawers) which make it look more "glossy" than the other icons. I am not saying this is the best fit - I just do not think the current one is one of the better ones.

@clobrano most suru icons give the "context" by putting a symbol on a baseplate. Baseplate: square Symbol: folder https://dribbble.com/shots/2445623-Suru-App-Icons image image

http://docs.ubports.com/projects/icons/en/latest/

Edit: about going back and forth - I know it sucks but if I have a concern about something I note it down

clobrano commented 4 years ago

Really, my only point was to decide for one - old or new - if we all are happy and can live long with it, or keep the current otherwise, I am more than open to proposals.

Feichtmeier commented 4 years ago

Ok great! Just to get it more in line with the suru/yaru icons and to note some ideas on how those icons are made:

("my" proposal prbly has the white folder paper icon too big)

ubuntujaggers commented 4 years ago

Reshaping the original Suru icon to use one of our new baseplates would be easy - should I just make a PR so we can try it?

ubuntujaggers commented 4 years ago

I liked the old folder design, I think we mostly changed to a filing cabinet due to suggestions from others? Happy to give this a whirl 👍

chrisjbillington commented 4 years ago

I like the current one because it's distinctive - it's a distinctive colour and doesn't look like anything else.

I was under the impression there had been a shift away from uniformity of icons in GNOME (not sure about Yaru actually) toward more heterogeneity, party due to the desire for more distinctiveness between icons, and partly out of practicality so that icons that are not part of a set don't stick out like a sore thumb.

Anyway, +1 for blue filing cabinet FWIW!

Feichtmeier commented 4 years ago

Fixed by https://github.com/ubuntu/yaru/pull/1756

Feichtmeier commented 4 years ago

Reopened for further discussion

ubuntujaggers commented 4 years ago

In the post squircle world, we've had three iterations of this icon, and I like them all:

The filing cabinet has the advantage of closely resembling Adwaita:

image

...but whatever we go for has to be "safe" (in terms of no one really dislikes it) because it's a key app and goes on the launcher by default.

coxackie commented 4 years ago

I would vote for fill sized-folder, but I am happy with all. (By the way, are you guys interested in designing icons outside of the core gnome apps? If yes, I (or you) could open an app suggestions discussion if you wish.)

clobrano commented 4 years ago

We are interested as long as the application maintainers agree and are involved as well

On Tue, 21 Jan 2020, 10:48 pm Kostas Kardaras, notifications@github.com wrote:

I would vote for fill sized-folder, but I am happy with all. (By the way, are you guys interested in designing icons outside of the core gnome apps? If yes, I (or you) could open an app suggestions discussion if you wish.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/1755?email_source=notifications&email_token=AAWAAHSX5OLCJYYASHPHV6TQ65UT7A5CNFSM4KHUV7T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRMLLQ#issuecomment-576898478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWAAHW76Q24ZFYU4ESLHJTQ65UT7ANCNFSM4KHUV7TQ .

Feichtmeier commented 4 years ago

Files / Nautilus is a generic app and a gnome core app. I don't think the we need an ack here

We should focus on the best design imho

ubuntujaggers commented 4 years ago

How about this - warmer and less dark grey, with a bit of work on the inside of the folder to make it more pronounced (without resorting to a high contrast) in the full size version:

image

image

image

ghost commented 4 years ago

Sorry but I prefer the blue file cabinet icon, more easily recognizable and adding more variety in the Yaru icons.

Feichtmeier commented 4 years ago

We dont need more variety, we need to stick with the guidelines, or make a new guideline :)

ghost commented 4 years ago

When I talk about variety, it's actually in terms of color. I think the idea of the blue file cabinet icon should not be discarded. I think there must be a way to make it a little more "Yaru".

fitojb commented 4 years ago

A huge step backwards.

Amr-Ibra commented 4 years ago

I also agree that this is a step backwards. The cabinet icon is a better representation of a file manager app. A brown folder on a baseplate looks just like a folder. Upstream Nautilus icon is also a cabinet.

Feichtmeier commented 4 years ago

Screenshot_20200129-224614

Feichtmeier commented 4 years ago

That's Android 10 iOS looks the same Everyone and his mom knows that this is the file manager

ubuntujaggers commented 4 years ago

I think the folder metaphor is widespread enough that it's unambiguous in practice. It seems to be the most common choice (I know Windows includes a little holder but I wonder how many people know that's what it is). I think first time users wouldn't quickly guess that the filing cabinet is a file manager, a) because it's not seen in other OSes and b) because it's blue, which filing cabinets rarely are?

Feichtmeier commented 4 years ago

Exactly. No operating system uses the file cabinet. So the idea of a that metaphor being more obvious is false. Let's move on

fitojb commented 4 years ago

Please. Be. Coherent. You supposedly agreed in the past to:

  1. Follow upstream GNOME conventions to avoid BS PR disasters like the whole “Don’t theme my app”
  2. Avoid the use of background plates to make icons’ shapes different and distinctive and ease Yaru’s visual integration with third-party applications.

You now changed your mind 180 degrees on both these things, one release later?

Feichtmeier commented 4 years ago

Regarding 1):

We avoid those disasters by

We still use the Suru icon guidelines. And the old icon did not fit into the guidelines

I didn't change my mind. You need to keep those two topics separated from each other

Edit: wtf. We never agreed on avoiding background plates. We agreed on increasing the number of useable background plates from ONE to 5. Please stop making things up just to force your personal preference

fitojb commented 4 years ago

And the old icon did not fit into the guidelines

LOL, now you’re accusing @ubuntujaggers of not following his own guidelines, haha. I am not the one making up things to fit my narrative. What a funny and specific thing to accuse people of. Don’t project.

chrisjbillington commented 4 years ago

A brown/cream folder in a squircle is just so ... indistinctive. Here it is on my taskbar (dash to panel). It's a featureless, colourless blob, and easily the least distincitve or recognisable icon on there.

image

It's true that a folder is the most recognisable icon for a file browser, but what about a blue (or otherwise colourful) folder, and losing the squircle?

If the new folder icons weren't grey, I would propose making the 'files' icon identical to the 'home folder' icon. It would make more sense for an icon based on a folder to actually be the same as the yaru folder icon:

image

It being the 'home folder ' icon specifically would make sense since the file browser by default opens your home folder. But grey is even worse than brown and cream on taskbars - the purple edge of the folder icon saves it a bit, but not much. As I've complained about elsewhere (though others seem to not agree with me), the grey folder icons are low-contrast on dark backgrounds generally:

image

If you want to make the nautilus icon a folder, I wouldn't mind that, but I think the following would be better than the current arrangement:

clobrano commented 4 years ago

Let's calm down, everybody here has the same interest in making Yaru better. No need to laugh or get angry at each other replies.

Coherence is not in discussion. As said, we agreed on not using the same background for all the icons, and we agreed in changing the icons for a subset of applications. This is not an opinion.

Constructive feedbacks are most welcome

@chrisjbillington, it's good to have different perspectives. We considered only the default Ubuntu dock as reference, where the size is 48px and the icon is pretty easy to recognize.

image

ghost commented 4 years ago

I agree with @clobrano and @Feichtmeier. It is difficult for everyone to agree. We don't have the same tastes (the proof, I think like you, I prefer the blue file cabinet). But this conversation may have gone a little too far and some sentences are unfair. @madsrh, @clobrano, @ubuntujaggers and @Feichtmeier are doing a colossal work to maintain this project (and take into account all comments) and actively contribute. It is thanks to them that we have Yaru, the theme that we all love. I hope they can continue the work they do for a long time.

fcole90 commented 4 years ago

I think the cabinet looks more distinctive and also it would be in line with both the current Gnome design and the former Ubuntu style

image

image

I can also understand your concerns that it looks too much detailed and less origami than the others, but I would rather suggest iterating on the cabinet than having just the old folder.

Also, if you really prefer a folder design, I think that indeed it should not just be the former icon. It feels very out of place with the current restyle of the other icons. Perhaps just the folder icon (as was proposed) but with some distinctive colour or symbol could work.

In summary, while I'm more in favour of the cabinet, a folder design would be fine but just not the Suru one.

Extra - Icons from other desktop OS: image image image