ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

Suggestion: create a yaru libreoffice icon theme #1815

Closed Jupi007 closed 4 years ago

Jupi007 commented 4 years ago

This is not a bug, but I thinks it should be great to have a yaru icon theme for libreoffice, which actually looks very inconsistent with the rest of the OS :

Elementary icons looks too much "Elementary" elementary

Breeze icons (which at the moment seems to me to be the most neutral) looks too much "KDE" breeze

And Colibre icons are just too "Windows" 😈 colibre

I know it's a lot of work, so this is just a suggestion.

Feichtmeier commented 4 years ago

Could you link to the specifications?

madsrh commented 4 years ago

Thanks @Jupiter007-43 It's been on my wishlist for a while but it's a ton of work, so this proberly isn't going to happen in this cycle.

Jupi007 commented 4 years ago

@Feichtmeier Which mean (sorry I'm French) ? If it's the documentation I haven't found any resource (I've been searching since yesterday).

@madsrh Yes it's over a thousand icons... 😰 But it will look very great !

madsrh commented 4 years ago

Yes it's over a thousand icons... cold_sweat But it will look very great !

Okay, my comment was a bit misleading - I would love to see this, but I doubt that it will ever happen - especially if it's thousand icons 😬

it should be great to have a yaru icon theme for libreoffice, which actually looks very inconsistent with the rest of the OS

A much easier solution would be to default to a icon theme that fits better with Yaru (if any of them does)

Jupi007 commented 4 years ago

A much easier solution would be to default to a icon theme that fits better with Yaru (if any of them does)

Yes, it's a good idea, but there's really not a lot of themes available (https://libreofficehelp.com/change-libreoffice-default-look-and-feel/).

Bonus : some yaru icons in libreoffice !

Capture d’écran du 2020-01-28 21-20-21

I got breeze zip and replace some icons.

madsrh commented 4 years ago

@Jupiter007-43 I had a quick look at this and it's a WAY too huge task for us. There is 3760 files within one iconset 😵

I'll have to close the issue here. If anyone wants to step up to this "challenge" that would be fantastic!

We can't change the default icon theme in LO, so if you think there's a more fitting one to match Yaru, you'll have to file a bug against LibreOffice in Launchpad.

Thanks!

...And if anyone wants to have a look, the files are stored here: image

Jupi007 commented 4 years ago

I'm working on here: https://github.com/Jupiter007-43/libreoffice-style-yaru

Capture d’écran du 2020-03-04 13-13-26 Capture d’écran du 2020-03-04 13-15-18

Feichtmeier commented 4 years ago

Woah awesome! How far are you? Maybe we could still get this into 20.04 (it's not me to decide at all, just thinking about it)

Jupi007 commented 4 years ago

Most of the work is done: I replace all KDE blue with Ubuntu purple, rounded corners (table, ...), replace some icons with Yaru ones, and create some missing ones from scratch.

A few more screenshot:

Capture d’écran du 2020-03-04 15-35-56 Capture d’écran du 2020-03-04 15-37-47

I don't know if it should be ready for 20.04...

madsrh commented 4 years ago

@hellsworth Would it be possible to get this into 20.04 (if it's ready)?

Jupi007 commented 4 years ago

I'm going to attempt... but I can't promise anything 😉

Jupi007 commented 4 years ago

I will post some news here.

hellsworth commented 4 years ago

Would it be possible to get this into 20.04 (if it's ready)?

@madsrh If the yaru team gets an icon theme for libreoffice to me in time, then I can make this the default.

Feichtmeier commented 4 years ago

Awesome @hellsworth :+1: Will libreoffice be a snap or a deb in 20.04?

hellsworth commented 4 years ago

Will libreoffice be a snap or a deb in 20.04?

Most likely we will ship both.

Jupi007 commented 4 years ago

A preview (still work in progress), bundled in an extension:

yaru-theme.zip

Happy testing !!! 😊

madsrh commented 4 years ago

As much as I like the icons @Jupiter007-43 I don't think we should ship this by default. Have you checked out the work ubuntujaggers is doing with the Inkscape legacy icons?

image

Feichtmeier commented 4 years ago

Yes they need to work in both light and dark themes as libre office can't handle symbolic icons yet. As mads said, check out Stuart's inkscape branch

Jupi007 commented 4 years ago

The dark theme is separated:

Capture d’écran du 2020-03-05 18-44-09

yaru-theme-dark.zip

Do you mean that the same theme must support both light and dark variants (Breeze has two variants)?

madsrh commented 4 years ago

Do you mean that the same theme must support both light and dark variants (Breeze has two variants)?

Preferably one icon theme should work in both light and dark.

Jupi007 commented 4 years ago

Oh! So a symbolic icon set isn't a good idea...

All this is for nothing. It's sad. 😢 That doesn't matter I'll put it on my computer.

Jupi007 commented 4 years ago

Great job with Inkscape 👍

Feichtmeier commented 4 years ago

Nooooo it's not for nothing:

Take your light set, and create 1px black and 1px white outlines, then fill it with a color, similar to what stuart did with the inkscape icons

Feichtmeier commented 4 years ago

@Jupiter007-43 or... before I give some crap advice, better keep your hands calm until @ubuntujaggers is back from his break, he can give real advices

Jupi007 commented 4 years ago

OK, thanks!

Feichtmeier commented 4 years ago

He is not done yet, but here are some, maybe it's already an inspiration for indeas: Bildschirmfoto von 2020-03-05 19-50-05

Jupi007 commented 4 years ago

The Libreoffice Gtk dark theme support is (very) bad:

Capture d’écran du 2020-03-06 19-22-53 (Maybe custom style make this strange rendering with the left menu)

And some icons of the actual default theme (Elementary) are almost invisible (bold, underline, align, ...) and disabled icons are just desaturated and a bit lighter (which look bad on dark theme):

Capture d’écran du 2020-03-06 19-23-14

It's really difficult to work under these conditions... 😰

Jupi007 commented 4 years ago

I tested a mid grey icon set:

Capture d’écran du 2020-03-06 19-56-50 Capture d’écran du 2020-03-06 19-57-11

But it's too light on light theme and too dark on dark theme... 😑

Jupi007 commented 4 years ago

Grey icons on white background:

Capture d’écran du 2020-03-09 17-08-23 Capture d’écran du 2020-03-09 17-08-44

The visibility is good on both dark and light theme. But each icons need to be edited one by one...

Jupi007 commented 4 years ago

I tested another grey (#808080) without white background and with light purple, which look pretty well on both theme:

Capture d’écran du 2020-03-11 14-54-59 Capture d’écran du 2020-03-11 14-55-21

yaru-theme.zip

Can I get your opinion: which one is better with or without white background?

Feichtmeier commented 4 years ago

I think you need @ubuntujaggers opinion here. I think your border needs to be way darker to look good in the dark theme. And the icons need to be indeed filled like you've showed in the comment above :)

madsrh commented 4 years ago

This one was really great 🎉Maybe a bit more color than just white, is probably needed IMO 😀

ubuntujaggers commented 4 years ago

Visually I think the mid grey symbols with people accents look smart and cool... but the problem I have with monochrome buttons in apps with many buttons is, nothing catches my eye. E.g., I use GIMP all the time, but whenever I need a particular tool I have to look at them one by one till I find it ☹️

What do you think of the 16px legacy icons in Master currently? They're like halfway between a full colour icon and a symbol and many of them are based on symbols. It's an easy style to do, if you like them it would be good to get a second pair of hands on the project if we want to target as many apps as possible (including LO). Likewise @madsrh could join in if he fancies 👍

Jupi007 commented 4 years ago

I use GIMP all the time, but whenever I need a particular tool I have to look at them one by one till I find it frowning_face

I'm in the same case, that's why I use the color icons in Gimp 😉 (in Libreoffice I got used to symbolic).

In fact, it was simpler for me to use Breeze as a starting point because I only had to round some corners and change the blue to purple (among other things). And also...symbolic icons are very easy to create! There is three size 16px, 24px and 32px, most of them are very specific and there is a lot of declensions. There is about more 3000 icons! I will try with some of the legacy icons, but it will take much longer... Certainly won't be ready for 20.04 (it was my target 😢). That doesn't matter, maybe 20.10! 😃

it would be good to get a second pair of hands on the project if we want to target as many apps as possible (including LO).

If there's anything I can do, let me know!

ubuntujaggers commented 4 years ago

@Jupiter007-43, would be great to take some of the legacy icons for common functions (e.g. print) and see how they look in LO 👍

Jupi007 commented 4 years ago

Et voila !

Capture d’écran du 2020-03-13 11-56-38

Capture d’écran du 2020-03-13 12-03-39

Just 2px too small (I didn't take the time to resize them). It look great on both theme 👍

Feichtmeier commented 4 years ago

Nice, thanks for the screenshots. In my opinion this could work! It's too late for a default in focal now but... Maybe we could provide a "libreoffice-icons-yaru.deb" later in the focal cycle? If you want to manage this task together with @ubuntujaggers don't stress yourself - it's a really huge task :)

ubuntujaggers commented 4 years ago

@Jupiter007-43 and I could start by targeting just the icons that appear on the top bar by default? Getting a Yaru set of those would be a great start 👍

madsrh commented 4 years ago

Where can I download this @Jupiter007-43 ? Could you upload this to your Github repo?

Et voila !

Capture d’écran du 2020-03-13 11-56-38

Capture d’écran du 2020-03-13 12-03-39

Jupi007 commented 4 years ago

The new repository is here: https://github.com/Jupiter007-43/libreoffice-style-yaru-fullcolor

Jupi007 commented 4 years ago

And the old: https://github.com/Jupiter007-43/libreoffice-style-yaru-symbolic

I still want to finish the symbolic version! 😋

Jupi007 commented 4 years ago

Some new screenshot (main toolbar, but some icons in other places are fullcolor too):

Small Capture d’écran du 2020-03-17 20-13-45

Medium Capture d’écran du 2020-03-17 20-13-18

Large Capture d’écran du 2020-03-17 20-14-39

But don't know how to render this kind of icon (just a letter) to fit consistency with overs 🤔 Capture d’écran du 2020-03-17 20-26-31

It looks strange like with just a white border...

Jupi007 commented 4 years ago

🎉 I finished the main toolbar of Writer on medium size: 🎉

Capture d’écran du 2020-03-20 15-02-02 Capture d’écran du 2020-03-20 15-02-21

What do you think of ? Can I resize them on Large and Small size, and make declensions ?

Feichtmeier commented 4 years ago

This looks really good, gj @Jupiter007-43 !

Jupi007 commented 4 years ago

I had forgotten masked icons, it's done now.

Capture d’écran du 2020-03-20 20-14-19 Capture d’écran du 2020-03-20 20-14-49

But my toolbar is a big mess now!

ubuntujaggers commented 4 years ago

This is starting to shape up really nicely :) Couple of thoughts:

image

Jupi007 commented 4 years ago

Capture d’écran du 2020-03-21 19-44-16 Capture d’écran du 2020-03-21 19-44-49

Much better without outline indeed 👍

About the letter icons, I've tried some concepts but I can't find one that looks nice and with a good contrast with light and dark theme in the same time... 😑

Jupi007 commented 4 years ago

🎉 I finished resizing Writer main toolbar icon to large and small sizes:

dark large dark medium dark small light large light medium light small

And I started working on the table toolbar (medium icons):

table dark table light

Jupi007 commented 4 years ago

Other thing, what do you think of these font based icons?

Capture d’écran du 2020-04-09 20-14-27 Capture d’écran du 2020-04-09 20-14-54

ubuntujaggers commented 4 years ago

Great work @Jupiter007-43 - those text-based icons look pretty smart!