search

ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.36k stars 186 forks source link

Snap store category icons are incomplete #2001

Closed Feichtmeier closed 4 years ago

Feichtmeier commented 4 years ago

Snap store has much more categories than gnome software. We are missing many of the icons, even if it's only a missing symlink.

These are the categories we provide: https://github.com/ubuntu/yaru/tree/master/icons/Suru/scalable/categories

@kenvandine could you give us a list of the category icon names you look up? Then we can make them completely yaru styled. Thanks in advance ! :)

kenvandine commented 4 years ago

Snap store has much more categories than gnome software. We are missing many of the icons, even if it's only a missing symlink.

These are the categories we provide: https://github.com/ubuntu/yaru/tree/master/icons/Suru/scalable/categories

@kenvandine could you give us a list of the category icon names you look up? Then we can make them completely yaru styled. Thanks in advance ! :)

https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store-packagekit/plugins/snap/gs-plugin-snap.c#L166

Line 166 through 240

meetdilip commented 4 years ago

So it will be

  1. Games
  2. Finance
  3. Development
  4. Social
  5. Music and Audio
  6. Productivity
  7. Utilities
  8. Photo and Video
  9. Sever and Cloud
  10. Arts and Design
  11. Books and Reference
  12. Devices and IoT
  13. Education
  14. Entertainment
  15. Health and Fitness
  16. News and Weather
  17. Personalisation
  18. Science
  19. Security

Are these supposed to be full-colour Yaru style or Symbolic ?

meetdilip commented 4 years ago

If it is something like this, it is easy to make

games categories

Feichtmeier commented 4 years ago

Symbolic only @meetdilip Thanks for the list ! :beer:

meetdilip commented 4 years ago

I used a Yaru template. In case that makes any difference

games yaru

Posted at the same time :)

meetdilip commented 4 years ago

Does this count as symbolic ?

finance categories

finance categories symbolic

meetdilip commented 4 years ago

How about using this as a template for Snap Store category icons ? We can fit in indications inside that circle. Easy to align and mixes with other elements in the snap store window

generic categories

meetdilip commented 4 years ago

Tried the full set. I had to use some icons from Material Design and others

image

(EDIT: Sorry @meetdilip, I accidentally edited this instead of replying! I've put it back again. @ubuntujaggers.)

Feichtmeier commented 4 years ago

@meetdilip thanks for the idea - let's see what @ubuntujaggers could use as an inspiration here :+1:

@ubuntujaggers this is the current snap store with gtk-common-themes from edge - so I think it should be the yaru master from after 19.10 (old gtk theme, but category icons look like what we have in master): image

Categories not in your C file, I guess because they are sucked from gnome-software? @kenvandine But here we have Yaru icons anyways, so not on the to-do list image image image

meetdilip commented 4 years ago

Photo & Video and Entertainment has the same icons.

Not criticising, but a camera icon for Art& Design ?

Communication & News has a similar icon as Social.

Apart from these very minor things, great work.

Feichtmeier commented 4 years ago

Let's keep this issue as clean as possible to get it done until 20.04 List is there, now we need pull requests for Books and Reference: accessories-dictionary-symbolic 👍

ubuntujaggers commented 4 years ago

Not criticising, but a camera icon for Art& Design ?

Fair challenge - that design made more sense in Gnome Software, because the category there is called Graphics & Photography. However, the same symbol turns up in Snap Store where "Photography" isn't mentioned :) From this, I learned the danger of swapping out the metaphor that upstream uses (because another app might choose the same symbol based on how it looks upstream).

The good news is I improved this a while ago in Master, as you can see in the latest Gnome Software:

image

...and I guess we just have to wait for the "common themes" version of Yaru to update before we see the change in Snap Store?

Feichtmeier commented 4 years ago

@kenvandine alrighty, Stuart added

image

But now you need to make sure to use the "-symbolic" suffix for your education category :smiley_cat:

Feichtmeier commented 4 years ago

Apart from some icons still missing from either wrong icon names in the snap-store C file or from our side with missing icons... is it really needed to expose so many categories to the user @kenvandine ? Many categories are also doubled and or almost the same.

kenvandine commented 4 years ago

That's defined by the store. We would need to redesign how the categories are selected to change that. Which I would be interested in doing, just not going to happen in the near term.

Feichtmeier commented 4 years ago

Okay, thanks for the reply @kenvandine :+1:

About the health categories: any idea how we could name this icon? https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store/plugins/snap/gs-plugin-snap.c#L224 Eventually applications-health-symbolic ? :thinking:

kenvandine commented 4 years ago

I don't have an opinion on the name. This is blazing new paths, so I'll use whatever name you would like to provide in the theme.

On Fri, Mar 6, 2020 at 11:34 AM Feichtmeier notifications@github.com wrote:

Okay, thanks for the reply @kenvandine https://github.com/kenvandine 👍

About the health categories: any idea how we could name this icon?

https://gitlab.gnome.org/Community/Ubuntu/gnome-software/-/blob/snap-store-packagekit/plugins/snap/gs-plugin-snap.c#L224 Eventually applications-health-symbolic ? 🤔

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/2001?email_source=notifications&email_token=AAANMBKR3J7VJIS6LLJNE3TRGDGTPA5CNFSM4K47Y5BKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOA4MJI#issuecomment-595707429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAANMBKH4AVGNCCBWEOQVI3RGDGTPANCNFSM4K47Y5BA .

-- Ubuntu - "I am what I am because of who we all are"

Feichtmeier commented 4 years ago

@ubuntujaggers

you think this would be okay for applications-health-symbolic? image

meetdilip commented 4 years ago

Sorry to crash in. I saw the file for health and fitness icon as

icon = NULL; // FIXME: needs a better icon

I have a couple of suggestions. For symbolic, we could simply use a grey scale version or even drop the fill

health heart

health steps

Feichtmeier commented 4 years ago

@kenvandine alrighty, it's going to be applications-health then :+1: The rest of the icons is actually already in yaru, there is just something missing in gtk-common-themes here, we / I need to investigate what's actually happening. With snap-store from edge and adwaita everything is fine, except the Health icon

Feichtmeier commented 4 years ago

@kenvandine applications-health is in yaru master now so you could use it for the health and fitness category :+1: image Closing the issue here since the list is complete from our side