ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.34k stars 179 forks source link

Make Yaru compatible with budgie-panel #2078

Open speltriao opened 4 years ago

speltriao commented 4 years ago

At the current state, using Yaru in budgie panel is almost unreadable. Is it possible to make a budgie-panel theme for Yaru?

Screenshot from 2020-03-16 11-53-05

Feichtmeier commented 4 years ago

If you give us the style classes sure

Coeur-Noir commented 3 years ago

From https://discourse.ubuntubudgie.org/t/help-needed-to-produce-yaru-budgie/4612 β‹… https://github.com/vinceliuice/Qogir-theme/blob/master/src/_sass/gtk/apps/_budgie.scss β‹…Β https://github.com/UbuntuBudgie/pocillo-gtk-theme/blob/master/src/gtk-3.0/3.22/sass/apps/_budgie.scss

Panels are a thing but applets inside panels have also to be checked, pixel-saver and global-menu amongst others. https://github.com/adapta-project/adapta-gtk-theme had fixed most.

speltriao commented 3 years ago

Hello. I made a .CSS specific file for Budgie-Desktop and Yaru-Dark (since it's the only version that I use). Here's the link: https://github.com/speltriao/Yaru-Dark-Budgie-theme

Note that I'm not a designer by any means, and only know the basics of CSS. This file is basead on Marwaita Ubuntu, but with Yaru's specific colors and flat design.

I think that it should be revised (since it's an amateur's work) and then converted into SCSS. Sadly, I don’t have the free time to learn any of this, so any further help is appreciated.

print

bashfulrobot commented 3 years ago

Just to throw a little comment in here. I was listening to the Ubuntu podcast, and Martin from Mate made a comment around how it would be great if the multiple Ubuntu flavors had a little bit more of a cohesive feel between each other. His view was around if the flavors were interested to base the theme on yaru but make it a little bit their own. I don't necessarily disagree with this. Especially because this team is doing such excellent work.

We (Ubuntu Budgie) have been giving this a little bit of thought. I'm wondering if there is an opportunity here for a little bit of collaboration between the Yaru group, and the UB group. Similar to what happened with Ubuntu Mate.

Any thoughts around this?

Muqtxdir commented 3 years ago

Hi @bashfulrobot,

if the flavors were interested to base the theme on yaru but make it a little bit their own

As mentioned by @Feichtmeier currently yaru-theme-gtk does not include _budgie.scss under gtk and would require/need help with getting those style-classes into a separate .scss file (i.e. is _budgie.scss).

The yaru-theme-gtk is supplemented nicely with the yaru-theme-icon and apart from getting the style-classes of budgie into yaru, it will also require changes and addition to the yaru-theme-icon to cover all the interface-icons used by budgie-desktop.

Personally, I'd be happy to see addition of yaru on Ubuntu-budgie and can help with icons, but let's see what others have to say on this

bashfulrobot commented 3 years ago

Okay, sounds good! I'll continue to monitor the thread. πŸ‘

Feichtmeier commented 3 years ago

Hi @bashfulrobot,

if the flavors were interested to base the theme on yaru but make it a little bit their own

As mentioned by @Feichtmeier currently yaru-theme-gtk does not include _budgie.scss under gtk and would require/need help with getting those style-classes into a separate .scss file (i.e. is _budgie.scss).

The yaru-theme-gtk is supplemented nicely with the yaru-theme-icon and apart from getting the style-classes of budgie into yaru, it will also require changes and addition to the yaru-theme-icon to cover all the interface-icons used by budgie-desktop.

Personally, I'd be happy to see addition of yaru on Ubuntu-budgie and can help with icons, but let's see what others have to say on this

We can put as many desktop stylings into yaru as there are, it's just that the work has to be done. The first step is to split up this fat _apps.scss file and backport mate styling from the mate branch into master

See https://github.com/ubuntu/yaru/issues/2620 And https://github.com/ubuntu/yaru/issues/2393

Feichtmeier commented 3 years ago

Ehhh that sounded so unfriendly @bashfulrobot hello there 😊 πŸ‘‹ I should probably be not on GitHub when the cats woke me up early

We've settled down with design currently so this should be doable next cycle (21.10)

bashfulrobot commented 3 years ago

I never took a single thing that was written as unfriendly. πŸ™‚ πŸ‘

Everyone has a limited amount of time, sometimes it is just about getting the root information communicated.

I look forward to following this thread. It sounds like there are a few structural changes that need to happen first.

On Thu, 15 Apr 2021 at 23:42, Frederik Feichtmeier @.***> wrote:

Ehhh that sounded so unfriendly @bashfulrobot https://github.com/bashfulrobot hello there 😊 πŸ‘‹ I should probably be not on GitHub when the cats woke me up early

We've settled down with design currently so this should be doable next cycle (21.10)

β€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ubuntu/yaru/issues/2078#issuecomment-820950982, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSIRIOLQFAXZK4IPEKV6X3TI7L7BANCNFSM4LMJ4XLA .

Coeur-Noir commented 3 years ago

It sounds like there are a few structural changes that need to happen first. I'm not sure how I can help here, not being a Β« coder Β» myself. I have made observations regarding how (Ubuntu)Budgie is currently styled and how currently all themes don't handle all applets same way for example ( even Β« officially Β» shipped themes like pocillo or arc ) https://discourse.ubuntubudgie.org/t/adapta-and-pixel-saver-applet/661/19?u=coeur-noir

Is this what you meant by structural changes @bashfulrobot ?

bashfulrobot commented 3 years ago

It sounds like there are a few structural changes that need to happen first. I'm not sure how I can help here, not being a Β« coder Β» myself. I have made observations regarding how (Ubuntu)Budgie is currently styled and how currently all themes don't handle all applets same way for example ( even Β« officially Β» shipped themes like pocillo or arc ) discourse.ubuntubudgie.org/t/adapta-and-pixel-saver-applet/661/19?u=coeur-noir

Is this what you meant by structural changes @bashfulrobot ?

My comment was around the earlier comment by @Feichtmeier that stated:

The first step is to split up this fat _apps.scss file and backport mate styling from the mate branch into master

It was more around the required "order of operations". πŸ‘

ItzSwirlz commented 2 years ago

Hey everyone, came across this. Here is my concern, as I'd love to try this:

If Budgie is going to switch from GTK to Enlightenment's toolkit, would GTK theming still be used? Enlightenment theming would be the way to go if Buddies of Budgie switch toolkits and it wouldn't make sense to create a theme - it would rather just have its own separate repo.

If said Budgie 11 is not coming out for a few years, it can be considered. But if the the theming changes with the toolkit, the yaru theme minus well should not be developed with the rest of the suite.