Cursor animation with outdated color.

[Initu-Castilhos]

The color of the cursor animation is blue and does not match the color of the system. My suggestion is to change the color to Purple (Ubuntu standard) and green (Ubuntu-MATE).

[Feichtmeier]

We could try light aubergine, but I fear it might look too dark. Or orange @madsrh ?

[madsrh]

Sure, sounds very logical 👍

[Feichtmeier]

Edit: gtk spinner:

Test PR https://github.com/ubuntu/yaru/pull/2780 But it needs rendering, I fail to render this @Jupi007 could you render this into this test branch? :angel:

[Jupi007]

@Feichtmeier I rendered the cursors (Btw it looks very good), I also synced Gtk4. In fact you need to remove the .png files you want to render inside bitmaps and also use Inkscape 0.92 (I used my 20.04 VM).

I think the purple used on Gtk spinners should be lighten on dark theme.

[madsrh]

I think the purple used on Gtk spinners should be lighten on dark theme.

I think both light, dark and cursor could be a bit lighter/brighter. IMHO the purple feels a bit too strong compared to the current blue, but maybe that's just because we've had the blue for so long.

EDIT: I did not try the PR yet, so this is just looking at the screenshot 🤷‍♂️

[Feichtmeier]

https://user-images.githubusercontent.com/15329494/113938379-d4a2f680-97fa-11eb-9039-f68b11422a94.mp4

https://user-images.githubusercontent.com/15329494/113938543-0caa3980-97fb-11eb-9a26-053b895b226c.mp4

Some footage

[Jupi007]

You can also see the spinner inside the Gtk-widget-factory.

[Feichtmeier]

Let's postpone this to the next cycle. I'm still a bit torn

[Benni3-1415]

The copy and the drag and drop copy cursors are in blue too. Some suggestions:

Ubuntu: Primary (Orange)	Mate: Primary (green)	Success (green)
:star: My favorite

[Feichtmeier]

I would go for orange too. And I think we should go also for orange for the spinners. Making thing overly complicated with all those many colors everythere does not really help

[Benni3-1415]

IMO, we need a design guide that clarifies such questions, for example:

Accent colors

Primary (orange #E95420)

for things that the user actively does (focus, active) so the user can directly see, what he is doing. I. e.: select a file, drag and drop, active form input

Secondary (aubergine #924D8B)

for passively things or those the user can't influence directly. I. e.: slide-bar, checkbox, (wallpaper), wait for the system, other colored things

Active (transparent grey)

for things that the user has done or could do (hover, enabled) (same design conditions like in Gnome 40). I. e.: hover on list item, active tab, active menu

Danger / error (red #c7162b)

for destructive (irreversible) actions. I. e.: Delete Permanently (file), uninstall application, (close window)

Success (green #109b26)

for constructive or confirming actions. Submit a form (i. e.: New Folder, Open File, send email)

[Feichtmeier]

I would generally agree with such static styling. But we've played around with this for years and this very burning orange only looks good when it is drawn in small elements such as stripes and little gems. The checkbox and switches look better with the light aubergine we currently use. I know it's inconsistent but it looks much better. This issue is about removing the blue out of the palette which is good.

Isn't the plus cursor rather a success action?

[madsrh]

IMO, we need a design guide that clarifies such questions...

Do you have any thoughts here @elioqoshi ?

[Benni3-1415]

What I wanted to say is that orange should only be used where something happens.

Isn't the plus cursor rather a success action?

I don't think so. You don't confirm something while dragging, you are doing something like you do something with an input form (and don't confirm it).

[Feichtmeier]

@Benni3-1415 sucking you back into this issue, I think even though the light aubergine looks good on a white disk, it looks bad in the dark gtk and shell themes as a spinner. That is the reason why we don't like the dark disk in the wait cursor, right? That is why I would personally go for full orange for spinners, cursors and progress bars. But I know that others may disagree :)

[Jupi007]

@Benni3-1415 sucking you back into this issue, I think even though the light aubergine looks good on a white disk, it looks bad in the dark gtk and shell themes as a spinner. That is the reason why we don't like the dark disk in the wait cursor, right? That is why I would personally go for full orange for spinners, cursors and progress bars. But I know that others may disagree :)

I agree in all points, except for progress bars. I love our purple ones (I know this is not an argument 😅).

[Benni3-1415]

Summary of #2804

Cursor spinner as add-on

If we see the spinner as an add-on to the cursor we could color it's border black and it is styled like the rest of the add-ons. Next problem: Why are the add-on colors inverted? :+1: 1

---

:+1: 1

---

Cursor spinner with dark bg

:-1: 4

---

:arrow_up_small: also used in an older version of Suru :confused: 3 | :-1: 2

[madsrh]

If we see the spinner as an add-on to the cursor we could color it's border black and it is styled like the rest of the add-ons. Next problem: Why are the add-on colors inverted?

@Benni3-1415 I understand what you are doing, but I really liked 😄 this idea?

[Benni3-1415]

Is there really no way to convince Canonical to lighten up their light aubergine or to define our own very light aubergine?

[Feichtmeier]

When you lighten up it even further it becomes pink. Let's just go with orange. Orange is the main accent color of ubuntu, let's embrace it

Edit: there is one more alternative we didn't think about yet... we could change the cursor to white + light aubgerine spinner, but revert the gtk spinner back to upstreams "text color" spinner, in this case it would be just #f7f7f7 for the dark theme, and #3b3b3b for the lighttheme, because the purple spinners really do not work for the gtk theme https://github.com/ubuntu/yaru/issues/2779#issuecomment-815283965

[Benni3-1415]

To your idea @Feichtmeier, we could make the cursor white too:

If we see the spinner bg as the dark add-on border both spinner and copy cursor would look not boring and consisted.

[Feichtmeier]

Okay this looks cool 😃

[Benni3-1415]

The pointer watch cursor looks fine, but maybe there is a bit too much color for the normal watch cursor, right?

[Feichtmeier]

Hm don't know would need to try it, I like the idea on the first look. We can then also change the gtk spinner to monochrome and be done with this topipc (and keep prple progress bars)

[Feichtmeier]

@Benni3-1415 could you include those changes in your pending cursor PR?

[Benni3-1415]

I think it's a different topic, I create a new one ...

[Benni3-1415]

Changes

Can someone else change the gtk theme, I don't know how to do it yet ... :slightly_smiling_face:

[Feichtmeier]

working on it: merged

[Benni3-1415]

Do I have to build it, or is it enough to run the render-cursors.py script?

[Feichtmeier]

After changing the cursor SVGs you need to render the cursors, yes. but there is more to do I think. those X11 cursors? @ubuntujaggers @Jupi007 pleas help Benni

[Benni3-1415]

I find it very irritating that it makes a difference whether you build the repository or not, normally only the source code is in the repository. I think I'll do a PR in the future to simplify the building process ...

[Feichtmeier]

If this is easier for you, you can just cretae one pull requests for both of your changes, we merge it, and our icon specialists render it when they come back, okay?

[Benni3-1415]

Yes, good idea, I don't get the build correct.

The PR for this issue: #2885

[Feichtmeier]

Both of your PRs work on the same file - the chance is high that this result in a git conflict. The best thing would be if you would include this change in your older PR

[Benni3-1415]

Yes, I forgotten, merging the images would go terribly wrong!

[Jupi007]

After changing the cursor SVGs you need to render the cursors, yes. but there is more to do I think. those X11 cursors? @ubuntujaggers @Jupi007 pleas help Benni

Sorry for the long no-response, I was absent yesterday and today, and on top of that, I can't start Telegram anymore 😞

Well, I think you need to run w32-make.sh and x11-make.sh inside the icons/src/cursors folder to render cursors.

[Feichtmeier]

Np! Hope you are okay?

w32-make.sh does not work, it complains about the other script to be not existent even if it does. doubled checked the path 🤷 no idea

[Jupi007]

Np! Hope you are okay?

Alright, thanks :)

w32-make.sh does not work, it complains about the other script to be not existent even if it does. doubled checked the path shrug no idea

Just tried w32-make.sh and that indeed do not work. It says many and many times this:

Traceback (most recent call last):
  File "../anicursorgen.py", line 28, in <module>
    from PIL import Image
ImportError: No module named PIL

I checked and I have python3-pil installed. @clobrano An Idea?

[clobrano]

I'll have a look

[clobrano]

well, basically it is based on python2, it needs rework :muscle: