Open sith-on-mars opened 3 years ago
Hi @sith-on-mars Thanks for reporting this. Yaru isn't a light or dark icon theme, it should work in both.
What do you think @Jupi007 @ubuntujaggers could this be fixed simply by adding symlinks to existing yaru icons?
Hmm, not sure - this looks like a bit of a weird one, I'm not sure why it's falling back to Breeze Light? I guess the problem is even if we have symbols (which take the local text colour) then the app might colour them dark, I guess because it's expecting a light background colour. Normally with Yaru you'd expect the stuff under the title bar to be pale (like LO) 🤔
Could you elaborate what " Adwaita Plus dark" is? Is this a special custom icon theme?
We must understand that this could be a tough task
Could you elaborate what " Adwaita Plus dark" is? Is this a special custom icon theme?
We must understand that this could be a tough task
* KDE app * monochrome yet PNG
Adwaita Plus dark is just the dark theme of Adwaita Plus icon theme. I edited my original post for avoiding confusion.
Hmm, not sure - this looks like a bit of a weird one, I'm not sure why it's falling back to Breeze Light? I guess the problem is even if we have symbols (which take the local text colour) then the app might colour them dark, I guess because it's expecting a light background colour. Normally with Yaru you'd expect the stuff under the title bar to be pale (like LO) thinking
I think generally if non-monochrome icons (like in Adwaita or Yaru) are not too bright or too dark, they should be fine regardless of dark/light theme. In LibreOffice there are a few icon themes that work both on light and dark theme well.
I think generally if non-monochrome icons (like in Adwaita or Yaru) are not too bright or too dark, they should be fine regardless of dark/light theme. In LibreOffice there are a few icon themes that work both on light and dark theme well.
Ah, I thought these were symbolics - yes, if they're colour icons then a middle tone will show up on both 🙂
My next question then is whether the icons that Okular uses are part of the free desktop specification. If they are then the legacy actions project would cover it.
I found the Yaru Plus icon theme, which is made by the same author of Adwaita Plus. Yaru Plus covers some of the missing icons, but not all of them. Maybe you could take a look?
My next question then is whether the icons that Okular uses are part of the free desktop specification. If they are then the legacy actions project would cover it.
Not quite sure what does it mean. Could you elaborate?
Basically, there are some "standard" buttons that are used across multiple apps. If the ones that Okular uses are part of that set, I'm slowly working through proving them all as a project, so we'll be covered by that work.
I think those icons are "standard" buttons used across different apps, and perhaps more popular among Qt apps? For example QOwnNotes also use many same icons.
I'm on OpenSUSE Tumbleweed Gnome.
It seems Yaru doesn't support the most of the icons for Okular and just falls back to Breeze light.
Here is an example in Okular with Yaru:![1](https://user-images.githubusercontent.com/37974764/118532230-3e85b880-b736-11eb-9e68-9df018cd9be3.png)
Could we have icons for Okular, please? I think you could look at Adwaita Plus or Papirus for reference. Or maybe you could create another Yaru dark theme as a temporary solution before the new icons are created, so that at least Yaru can fall back to Breeze dark in the dark mode.
Here is what Okular look like in Adwaita Plus dark:![image](https://user-images.githubusercontent.com/37974764/118533119-324e2b00-b737-11eb-8aa8-9fe034272a4f.png)
Here is what Okular look like in Papirus dark:![2](https://user-images.githubusercontent.com/37974764/118532592-a9cf8a80-b736-11eb-9a23-d0c6f5916249.png)