Orange in close button

[godlyranchdressing]

While I did like the orange background before, I think if we're removing it then it should be completely removed instead of having it only show up when hovering. It looks strange to me.

[ghost]

I think too that it looks strange when hovering. But it is more the way how it looks. Orange circle over a squircle does not look good IMO. Yes, removing completely would be nice. I am still a fan of this idea for hover:

[madsrh]

How about bringing it back? :speak_no_evil:

As I've mentioned earlier, the current design looks a bit neutral/sad/unbranded/... to me. IMHO I really liked the closebutton + orangesidebar we had before - it really feelt like Ubuntu.

[Feichtmeier]

+1 for bringing it back My father also loved the close button as it is a great indicator for where to navigate with the 🐁 So it's basically +2 :laughing:

[clobrano]

I didn't dare to say it, but I'll be very glad to have back both, or at the very least the orange sidebar.

[ghost]

oh god, please no!

Could we please use real arguments? The constant orange close-button:

• a poll showed that users experience an optical illusion! This can be a distraction from work users are doing with their computer: https://community.ubuntu.com/t/call-for-participation-an-ubuntu-default-theme-lead-by-the-community/1545/835?u=nusi Is this theme for everyone or for the majority? I am really surprised that this is getting ignored after all.
• even without optical illusion, there is no reason to use a constant-glowing point on the desktop which screams for your attention. nice on screenshots. nice in starbucks. nice for short presentations but a pure distraction when people use the OS for a longer time-period
• the color orange is a pure attention-grabber and should be used wisely
• everyone knows where the close-button is, unless he is a new user

The orange background in the sidebar:

• same as close-button: unnecessary attention-grabbing for something that is already shown by the content itself and by the stackswitcher. There is just no logic at all to make the sidebar row this showy!
• the orange is too bright to use it as background for white text. Users can experience this as too shiny. Again: Is this theme for everyone or the majority with modern displays and good eyes?
• at the moment the selected sidebar row is the perfect equivalent to the stackswitcher

Please, just no. The theme has a style at the moment:

• gray, dark gray or white backgrounds for white or black text -> improves and guarantees readability!
• orange is only used in form of lines, rings and borders -> asks for the attention necessary, not more! It is only there where it is needed. This way the use of orange is functional and stylish/elegant at the same time. Orange warning lights and blocks are not functional on an OS which is used for work. The user wants to focus on the content! At the moment there is no other linux theme which follows its own rules this strict and keeps consistency. This is quality! And not a product of the taste of one designer. I do not think there was ever put so much thought into a theme.

These are the only arguments i read about going back:

• "IMO it looked better" -> this is not an argument
• "I miss it" -> this is not an argument.
• Branding! -> Yes, branding is good and important. Does this not look ubuntu-ish enough for you:

I use Ubuntu since Ubuntu 7.04 feisty fawn and never returned to windows. I have no dual-boot. I can tell you ubuntu never looked this modern and usable at the same time. When it is planned to have this theme as a default we should think about all the people who work with it. Users who only switch some days to ubuntu to play around and reboot to windows really would like a flashy shiny theme.

PLEASE let us use arguments and PLEASE let us not go back to the constant glowing light and the orange block. It was already proven and demonstrated that it is not user-friendly. At the moment i do not know anymore how to convince you that this would be the wrong way. Really frustrated here.

We could think about doing a second theme with all this shiny blocks and dots. We could have the communitheme and the communitheme PRO.

EDIT:

LESS is MORE!

[godlyranchdressing]

@NusiNusi I'd prefer for the close buttons to all be circles, honestly. I never liked the squircle effect + circle on the close button, it always looked like too much. And of course, my obligatory default argument: in Unity 8 they're all circles and the close button has a red background when hovering on it.

As for the orange bar for the sidebar, I've come to like the little strip but I still think selected rows could do with some more emphasis and the line effect could be similar to the stackswitcher. Right now I have to look for a microsecond to see the orange strip.

[CDrummond]

@NusiNusi As always, just my opinion, but... the close button is a destructive action, therefore this should be highlighted in someway. Hence liking the orange (or even red) circle (or background) to indicate that this button is different. Both Windows and macOS have a red background colour for the close button.

[Feichtmeier]

Ok here we go, I only speak for the close button though, because this is the topic of this thread, isn't it?

General arguments:

• there are many icons in the header bar, and the modern gtkheaderbar uses symbolic icons for every icon and this results in a focus loss if you want to close the window -> where is the close button?
• in non-perfect situations the thin close button becomes hard to see
• the orange close button gives the window a direction -> the top right

Arguments that consider users that used ubuntu and therefor ambiance before communitheme:

• ambiance has an orange close button since? I don't know, you could tell me, since I started to use ubuntu at 14.04 -> recognition value (Wiedererkennungswert)

Refinements if we keep the button:

• I heavily +1 @godlyranchdressing 's argument - this is my main problem with the current state, the mix of a squircle background and a circle button -> I would like to test a circles only window control panel (perma circle close button + hover circle background for min max)

[godlyranchdressing]

@Feichtmeier

^{Apologies for the weird gif. I'm using a touchpad.}

[Ads20000]

even without optical illusion, there is no reason to use a constant-glowing point on the desktop which screams for your attention. nice on screenshots. nice in starbucks. nice for short presentations but a pure distraction when people use the OS for a longer time-period the color orange is a pure attention-grabber and should be used wisely

@NusiNusi would you argue that the orange pips in the Dock should be scrapped as well then? What about the Firefox logo? And the desktop background? And the orange folders?

I'm not sure about the 'optical illusion' thingy, maybe that is a thing, maybe not, I don't know.

Is this theme for everyone or the majority with modern displays and good eyes?

You know there is a separate High Contrast theme? Or are you suggesting that there are a lot of people who have eyes which can deal with more than High Contrast but less than Ambiance?

It was already proven and demonstrated that it is not user-friendly. At the moment i do not know anymore how to convince you that this would be the wrong way. Really frustrated here.

A small poll of people who thought that the x moves within the orange circle whilst they turned their head = 'proven and demonstrated'? Hmm...... I think in these kinds of discussions sometimes you have to learn to accept that you might not be able to convince someone that your opinion is correct, you just have to accept what the others say (whilst noting your dissent) and move on, otherwise I imagine you'll get very frustrated in any argument?! You and I aren't on the design team for the Communitheme so we don't really get the final say on this.

[Ads20000]

I would like to test a circles only window control panel (perma circle close button + hover circle background for min max)

@Feichtmeier I would like a squircles only window control panel - the orange should either fill the whole squircle (and the close button in Activities should also be an orange squircle) or it should be scrapped entirely. Worth noting that the close tabs button in Firefox, Files and Text Editor are white, grey hover squircles so maybe, sad as it is, the window close button should be as well, or it should be orange because it's a more significant close button.

[ghost]

@Feichtmeier

there are many icons in the header bar, and the modern gtkheaderbar uses symbolic icons for every icon and this results in a focus loss if you want to close the window -> where is the close button?

This is a valid point. But shouldn't the position of the close-button be intuitive recognizable? We can think about real new users, children or old people. They could not know where the button is. But don't you think that after a few days of experience the user already knows where the close-button is? And this argument could be used for all buttons -> "where is the [...]-button?" So there could be a constant shining reminder of the close-button or other ideas could be followed: Some kind of introduction-video.

in non-perfect situations the thin close button becomes hard to see

Yes! It is too thin. I suggested to rework the control-buttons but there was no interest. What do you think about making them just a bit thicker?

the orange close button gives the window a direction -> the top right

I do not understand this argument. We should not forget that the shell-window-view already has an orange close-button. Do you remember the "issue" that we had two orange close-buttons next to each other? We would go back to that situation.

ambiance has an orange close button since? I don't know, you could tell me, since I started to use ubuntu at 14.04 -> recognition value (Wiedererkennungswert)

The orange close-button exists since ubuntu 10.04. BUT, and this is very important, the x was black. This way the orange close-button was not so shiny: (by the way, even now the x is black in ambiance)

I already used ubuntu when it still looked this way: You can imagine that the new "ambiance"-theme was a very big change.

You are right, "recognition-value" is important. And i am not against it. But it should not be a distraction. I think the dark headerbar and the orange icons icons and lines are already ubuntu enough. I do not think there is another OS that uses these colors.

I heavily +1 @godlyranchdressing 's argument - this is my main problem with the current state, the mix of a squircle background and a circle button

I agree 100%. But i think the orange should not be used permanently. Only when hover. My arguments for this are known.

@godlyranchdressing I really like the first one (close-button-gif). Red is used as a warning. Something destructive is going to happen. Your sidebar-gif looks very good and keeps the style. I would like to see it in the theme.

@CDrummond

the close button is a destructive action, therefore this should be highlighted in someway.

I agree! But i think this is only necessary on hover, not all the time. And the team said the orange close-button is used for "branding" and not for "warning". Not sure where but i could look that up for you.

Both Windows and macOS have a red background colour for the close button.

That is correct! But newer versions of windows dropped the orange:

And in MacOS the red circle has not a white x which would make it even shinier.

@Ads20000

@NusiNusi would you argue that the orange pips in the Dock should be scrapped as well then? What about the Firefox logo? And the desktop background? And the orange folders?

??? I am a bit confused. I am not against the use of orange in general. But i am against an excessive use of orange which hinders usability only in the sake of "branding" and "recognizability". Please read this here: https://github.com/ubuntu/gtk-communitheme/issues/289 The theme uses orange to show something is selected or active. It should stay this way.

I'm not sure about the 'optical illusion' thingy, maybe that is a thing, maybe not, I don't know.

yeah, it's a thing.

You know there is a separate High Contrast theme? Or are you suggesting that there are a lot of people who have eyes which can deal with more than High Contrast but less than Ambiance?

Ambiance looks like a toy compared to windows 10 or macOS. IMHO!

A small poll of people who thought that the x moves within the orange circle whilst they turned their head = 'proven and demonstrated'?

Yes! Not "thought", they really experienced it this way.

I think in these kinds of discussions sometimes you have to learn to accept that you might not be able to convince someone that your opinion is correct, you just have to accept what the others say (whilst noting your dissent) and move on

It is not an opinion. Arguments are not an opinion. You want my opinion? Orange looks stupid! Orange looks great!

otherwise I imagine you'll get very frustrated in any argument?!

Don't worry. I teach politics, history and literature. I argue every day. I get frustrated when arguments have no effect anymore. Everyone should be when this happens.

You and I aren't on the design team for the Communitheme so we don't really get the final say on this.

Thank you for the reminder.

[Ads20000]

Arguments are not an opinion.

I think they can be. It's your analysis of the evidence that there is an optical illusion and its your opinion that avoiding said optical illusion should be a priority - that's a normative view.

[clobrano]

To me, the theme lost a lot of personality in the last month, I am just happy about the last week, because the trend seems inverted.

Is this theme for everyone or for the majority? I am really surprised that this is getting ignored after all.

Of course it is for the majority. I would be awesome if something could be for everyone, but, honestly, how could it be? We are working hard to let the majority be as close as possible to everyone, but we cannot please everyone, nobody can.

And still we spent the last month and a half working on a lot on subtle differences, proposing, testing, reverting back and trying again and again and the bug count grown a lot. We are wasting a bit too much time lately.

I don't like to see arguments/opinions pushed other their natural limits only to promote your own ideas. A poll where only 19 people replied does not prove anything. The idea of "only when necessary" is of course an opinion, and yet the most of us tried to come towards other opinions. Not all of us, however, and this actually gets on my nerves sometimes.

We could think about doing a second theme with all this shiny blocks and dots

Or the other way around, don't you think?

Using bold text and exclamation marks only show frustration, I'd prefer not seeing it here. The last thing I see here wanted by only one person is the removal of the close button circle. Let's try to move together towards something we can share and appreciate.

[clobrano]

About close button hover circular, how does it look close to the the other buttons that use squircle?

[godlyranchdressing]

@clobrano

I can open a PR so we can test it live.

[clobrano]

Ok, so my idea was to initially test with the orange circle only on hover, what do you think?

EDIT: by the way, PopOS uses a persistent orange close button as well

[godlyranchdressing]

@clobrano if it'll only be visible on hover then I think it'll be better for it to be red. The orange here is only for personality/branding, so unless it's visible all the time, then the close button's more like a regular destructive button. Having the orange only when hovering won't have the same effect, so best make it red.

[Feichtmeier]

I would like to test it the way it's in this gif. Edit: because the squircle selection looks pretty strange with a circle close button what was the initial point of this issue

[clobrano]

You're right, it's in fact a destructive action, but not styled this way in the css. I'd prefer orange and permanent, to red :)

[ya-d]

The circles look a bit small to me but that can only be judged seeing them full screen. I would like to add one thing though:

There is an objective issue with the close button which maybe adds to the negative impression for some users. Because of the aliasing in the diagonal lines of the X it looses weight compared to the straight lines of minimize and close. This makes the close icon appear thinner and makes it vanish in the background (be it grey or orange). Maybe this can be offset visually by making the strokes a little bit thicker. See screenshot above.

(The same issue is visible for other icons which aren't exactly horizontal or vertical, like the magnifying glas. I use a high res screen, it's probably even worse on low resolutions.)

[clobrano]

@ya-d do you know where are the assets for this button?

[Feichtmeier]

You can change the color here: https://github.com/ubuntu/gtk-communitheme/blob/master/Communitheme/gtk-3.0/_common.scss#L4592 The close button is taken from "our" icon theme Suru =)

[ya-d]

I guess it's application-exit-symbolic.svg but I absolutely don't know where it lands in the OS.

[godlyranchdressing]

@ya-d That'll need to be changed in the icon pack. I think there's an issue open for it already.

[ghost]

@clobrano

Using bold text and exclamation marks only show frustration, I'd prefer not seeing it here.

The bold text was used for headlines to structure my text and for arguments that were already told and seemed to be completely ignored. I am repeating myself.

A poll where only 19 people replied does not prove anything.

This is not right. It proved that some people have this experience with the white text over this orange circle. This issue is not a fabrication from me to get rid from an orange dot as many of you seem to think. As i said in the ubuntu hub this can be ignored by you but that would mean that some users with glasses will see the x moving inside an orange circle. You do not experience it. Others in your team do not experience it but others and i experienced it and i took my time to tell you this so that a different solution can be found.

To me, the theme lost a lot of personality in the last month

This is your opinion. My opinion is the exact opposite because the theme gained a lot of consistency and avoided being a collection of subjective design-preferences. I am repeating myself once again but the theme is using orange in all places as lines, dots and borders to show something is selected or active. Why can't we follow this rule? If the close-button stays orange it has only a branding-purpose.

And still we spent the last month and a half working on a lot on subtle differences, proposing, testing, reverting back and trying again and again and the bug count grown a lot. We are wasting a bit too much time lately.

This is not because of me. The "bug counts" are growing because we are clearing consistency-issues. If you look at the recently opened issues you will see they are mostly about tiny refinements. The theme seems already finished.

"only when necessary" can surely interpreted as an opinion. I was using it as a guideline to give the use of colours and forms a purpose and logic. I do not understand why this goes on your nerves. This should make decisions even easier.

I am aware that my proposed ideas are not welcomed here at all and get immediate dislikes. This is done to no other helping hand here. They are not even used as a startingpoint for different ideas (really? the orange circle is the only alternative?) Many suggestions from me were repeated later by other users and suddenly got the attention they deserved. This is one thing that goes on my nerves: I am not the enemy and i am not trying to block the development or push my "opinions" over you. The only opinion i have: The use of colors should be consistent and follow a guideline. Without this red line you will turn in circles because it will be all about "i like this" and "no, i like that". You can later even justify the use of colors if someone asks. But i am pretty sure this will only be taken serious when someone else uses this words. Someone even felt the urge to remember me that i am not part of the team and i do not have the last word. I know there are some of you who want me to stop "helping" and most only think i want to get rid of the color "orange". Even when i explained multiple times the reason. No problem, i can stop "helping" if you feel this makes developing the theme easier. One last question for you: Is an orange circle with a thin white x the only option?

[clobrano]

Your opinions have been so ignored that we are still here talking about them.

You are considering only people with glasses in this illusion issue, while there might be tons of other possible causes, like display, light in the room, etc. However, I said that the poll does not prove anything, not that does not prove your point. I simply said that I am not going to use it to prove we can keep or remove the circle. That's it.

This is not because of me.

Of course not. The theme is not finished. We are almost at the same point where it's been decided to postpone it to 18.10. Few tests on GTK2, No test on Qt, no defined dark variant (some application uses it, so we are kind of forced to provide it).

the theme is using orange in all places as lines, dots and borders to show something is selected or active. Why can't we follow this rule?

The theme is doing this now, after the "remove orange" topic. Before that we had orange tiles that where fine to me, but since the majority agreed on remove them, we did. However, when pushed on some applications it makes the theme bland, neutral and unpersonal. Sometimes "it looks good" can be preferred to consistency. This is my opinion of course.

"only when necessary" can surely interpreted as an opinion. I was using it as a guideline to give the use of colours and forms a purpose and logic. I do not understand why this goes on your nerves. This should make decisions even easier.

You misunderstood. Below is what I wrote.

the most of us tried to come towards other opinions. Not all of us, however, and this actually gets on my nerves sometimes.

---

One last question for you: Is an orange circle with a thin white x the only option?

This idea comes from Ambiance, to let the user remember from where we came from. Anything that can give the same idea will be discussed, but I don't feel that using a red X will do.

I don't see you as an enemy at all, but sometimes I feel that for you or we agree or we are wrong.

[Feichtmeier]

My god so much drama... Nusi you know this is bullsh*t, you had some great ideas which we implemented. Just some things could not be implemented or could get reverted because other people are not +1 Look, for example me: I would like to do this or that and I propose the idea but when it's clear that there are not so many +1 I forget about it. That's what @clobrano was meaning, to know when to stop the pressure. Also, there is that PR with the close button which we test now nothing is set in stone. You should really calm down now and let's get back to work @.@ Just for taking things not so super srsly and a bit humor I give you this quote:

"The tribal wisdom of the Dakota Indians, passed on from generation to generation, says that when you discover that you are riding a dead horse, the best strategy is to dismount."

[CDrummond]

First of all - windows controls look great! - I love the new look.

Once slight niggle, when you mouse over the close button on a background/inactive window the close button's orange circle disappears.

[mivoligo]

IMHO the orange close button on every open window is not a very good idea. If you have few windows open you see orange dots everywhere. Also in the activity view you get 2 orange buttons next to each other which looks at least weird:

[clobrano]

@godlyranchdressing I think that it should not be orange on backdrop at least

[jim3872]

The x and the square doesn't look central to me with chrome in fullscreen. . It's ok otherwise.

With the side bar has it been tried with the orange similar to the radiance theme? I.e orange on 'hover-over' with nautilus but used as is for things like the settings menu. Could this be the best of both worlds?

[Feichtmeier]

This is a chrome problem check the other gtk themes. Same issue

[jim3872]

Pop OS theme is ok.

[Feichtmeier]

@madsrh @clobrano @godlyranchdressing you're okay with this for backdrop and backdrop hover?

[madsrh]

@Feichtmeier I think it should become brighter on hover like the other buttons 😉 The opposite might work

[Feichtmeier]

@madsrh like this?

[Feichtmeier]

Btw, this somehow reduces the problem with the "orange buttons everywhere"

[CDrummond]

(And, just to butt in where I'm not wanted...) If we have hover-effects for window buttons on inactive windows, surely we should have them for all widgets? ie. #194

[Feichtmeier]

You are always wanted! You mean like in ambiance?

[CDrummond]

(The bit in brackets was in jest). Anyway, most themes (Arc, Ambiance, Pop) react to hover for inactive windows. (Even windows does). But I was referring to all widgets, not just headerbar widgets.

[Feichtmeier]

@CDrummond alright. Let's discuss this in the other issue then :) I'll only work on the close buttons now - but good idea to bring this up again!

[madsrh]

@Feichtmeier Could we try @ubuntujaggers suggestion from the hub ?

Here's a quote:

Looking at the explanation of the colour use… I would say the odd one out is orange “x”. I actually like it and want to keep it, even though I was initially supportive of removing it (I realised how much I’d missed it when the orange circle came back!). But the use of orange here is pure branding. It doesn’t tie in with the general logic on colours. As always, just an idea: if you only have the orange “x” for in-focus windows, does that bring it in line with other uses of orange in Communitheme? Then the explanation is, the orange is being used as another visual indication of focus, current selection, etc… It doubles up as an orange highlight or “pip” on the selected window. That’s consistent with the current thinking around colour and can be justified if people ask why it’s orange (rather than just “it looks good” or “a tribute to the old theme” - explanations that convince me :slight_smile: but maybe not everyone). And the rationale for having the orange around the “x” would be, it’s a nice/tidy/obvious place to put a small bit of orange to show focus, without it being “too much orange”.

[Feichtmeier]

@madsrh Ah what I've done in that PR https://github.com/ubuntu/gtk-communitheme/pull/401 is this:

I think I've forgotten to link the PR in this thread some days ago :smile: Want no circle at all or is the grey circle in the backdrop ok?

[madsrh]

I'm closing this issue as it was fixed with https://github.com/ubuntu/gtk-communitheme/commit/0f120b2983c13f137a6cd71d41cb4e5266232ef3

[Feichtmeier]

@clobrano I've noticed that though CSD apps work as we designed them together with jaggers on the hub, the pressed/active grey circle disappears on non-CSD apps:

Any idea how this can be changed @clobrano ? :dancing_women: Is there a special class for non-CSD window controls?

[Feichtmeier]

Edit: found it... I've forgotten to include: &:backdrop:active{@include draw_circle(darken($headerbar_fg_color,40%), $close:true)}

-.-