search

ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.34k stars 181 forks source link

flatpak theme is broken #3766

Closed iaacornus closed 1 year ago

iaacornus commented 1 year ago

Expected Behavior

I was expecting it to be consistent and be the same for the system and flatpak.

Actual Behavior

It produces something like this:

Screenshot from 2022-11-07 04-58-40

Screenshot from 2022-11-07 04-58-16

Steps to Reproduce the Problem

It is present on both procedures:

  1. flatpak install flathub org.gtk.Gtk3theme.Yaru-Purple (version: 21.04, from: stable)
  2. and flatpak install flathub org.gtk.Gtk3theme.Yaru-Purple-Light (version: 21.04, from: stable)

or even if you:

  1. sudo flatpak override --system --filesystem=$HOME/.themes
  2. sudo flatpak override --system --filesystem=/usr/share/themes
  3. sudo flatpak override --system --env=GTK_THEME=Yaru-purple

Software that presents the issue

Almost all of the flatpak applications, in which either the theme is broken or it doesnt follow the theme.

Yaru version

22.10.3 for the system and 21.04 for the flatpak.

Screenshots

Screenshot from 2022-11-07 04-58-40 Screenshot from 2022-11-07 04-58-16 Screenshot from 2022-11-07 05-08-06 Screenshot from 2022-11-07 05-07-29 Screenshot from 2022-11-07 05-07-35

More info

I am on Fedora Silverblue 36 with Gnome 42.4, I installed Yaru via rpm-ostree, it works perfectly on system applications. As for flatpak, I tried to apply it with both of the methods I've given above (tried installing the flatpak package for yaru, doesn't work, then tried overriding the directories where they are located, also doesn't work). If there is any more info needed or help I would try my best to provide it. Thank you.

Jupi007 commented 1 year ago

@Muqtxdir Can you look at this one?

Muqtxdir commented 1 year ago

hi @iaacornus

could you tell what the application versions are that you provided in your screenshots?

iaacornus commented 1 year ago

they are (in order), gnome text editor, extensions, gnome clocks, gnome calculator, and gnome calendars, all are flatpak, there versions are:

43.0 for all, and 43.0.1 for the gnome calculator, all are libadwaita if I'm not mistaken.

Jupi007 commented 1 year ago

Well, this is (sadly) normal @iaacornus. Libadwaita apps are not aim to be themed. The Yaru Gtk4 theme is based on the pure Gtk4 one, which is incompatible with Libadwaita apps.

In early times of Gtk4/Libadwaita our theme was based on Libadwaita, but since these apps are blocking the theming feature, this makes no more sense, so we reverted to pure Gtk4.

So sorry, but this mean we can't fix your problem 😕 If you agree @Muqtxdir, I think we can close this issue.

iaacornus commented 1 year ago

understandable, thank you for responding, I'll close now the issue. Thank you.