search

ubuntu / yaru

All Ubuntu Yaru GNOME themes
https://community.ubuntu.com/c/desktop/theme-refresh
GNU General Public License v3.0
1.35k stars 182 forks source link

23.04 finger print message has no fg color specified #3897

Open Feichtmeier opened 1 year ago

Feichtmeier commented 1 year ago

grafik

in 23.04 in the light theme the finger print message has the wrong color. Eventually because it is not set via a variable here

https://github.com/ubuntu/yaru/blob/34d8feb713f62345f429c007f0f8d7da055615f7/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss#L45

Needs to be confirmed though that this is the reason

CC @3v1n0 @Jupi007

Jupi007 commented 1 year ago

Imo, that needs to be done is this:

 .caps-lock-warning-label, 
- .login-dialog-message-warning { 
+ .login-dialog-message { 
   color: $_gdm_fg; 
 }

Here:

https://github.com/ubuntu/yaru/blob/34d8feb713f62345f429c007f0f8d7da055615f7/gnome-shell/src/gnome-shell-sass/widgets/_login-lock.scss#L9-L12

Like this, it is targeting all messages and not only the warning ones.

adamhassel commented 6 months ago

Got annoyed with this recently, and this is the only place I found that mentions this issue. Was a fix ever committed?