Documentation and metadata

ubvu / open-handbook

https://rdm.vu.nl/

Creative Commons Zero v1.0 Universal

10 stars 17 forks source link

Documentation and metadata #236

Closed Elisa-on-GitHub closed 2 days ago

Elisa-on-GitHub commented 3 weeks ago

This PR adds the topics Data Documentation and Metadata as separate topics. There was an earlier PR that proposed to do this, #110 but that was closed when we realised we needed more time to implement changes and introduce these topics as two separate topics. The current topics were updated using both the input of the comments in #110 and from the metadata specialist.

Is there a way to give the metadata specialist credit as a contributor? I don't know his github handle and he's an inactive github user.

netlify[bot] commented 3 weeks ago

Deploy Preview for ubvu-open-handbook ready!

Name	Link
Latest commit	3d90912356030069d1cc1ce1a63bd6a649d95651
Latest deploy log	https://app.netlify.com/sites/ubvu-open-handbook/deploys/673daef2071769000813a4d0
Deploy Preview	https://deploy-preview-236--ubvu-open-handbook.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 19 Accessibility: 82 Best Practices: 100 SEO: 90 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

chartgerink commented 3 weeks ago

Thanks @Elisa-on-GitHub 🙌 You can add the name directly to the about.qmd file, if you'd like. There is a section for those contributing outside of GitHub 😊

It seems like the branch got outdated, so I will handle the conflicts for you on this PR.

Jolien-S commented 2 weeks ago

Hi @chartgerink 👋

Could you please have look at the conflicts? I'm not sure how to resolve those. I suggested two minor changes in my review and added them to the batch. I'm not sure this is the right thing to do. If you can help solving the conflicts and merging this PR, that would be great. Thanks in advance!

chartgerink commented 1 week ago

Thanks for the ping @Jolien-S 😊 I started working on this in the afternoon, but the conflict is substantial. Do you have any guidance on how best to decide what has priority?

The structure doesn't necessarily easily fit, so there are some judgment calls. Should i try to merge them as much possible, or should i let the new version take priority and flesh it out with anything that might've gotten lost in the meantime (like links)?

With your guidance I can move forward 🙏