search

ubyssey / dispatch

A publishing platform for modern newspapers.
GNU General Public License v2.0
69 stars 23 forks source link

Orm managers fix #984

Closed keeganland closed 4 years ago

keeganland commented 4 years ago

What problem does this PR solve?

Inappropriately high coupling in PublisherManager. Other apps' "View" logic way too dependent on this!

How did you fix the problem?

Got rid of the logic there entirely, moved it so it's literally in the Views in the other apps

codecov[bot] commented 4 years ago

Codecov Report

Merging #984 into develop will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #984      +/-   ##
===========================================
+ Coverage    82.92%   83.18%   +0.26%     
===========================================
  Files           45       45              
  Lines         2852     2843       -9     
  Branches       326      324       -2     
===========================================
  Hits          2365     2365              
+ Misses         417      409       -8     
+ Partials        70       69       -1
Impacted Files Coverage Δ
dispatch/modules/content/managers.py 100.00% <ø> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 838af5a...3866413. Read the comment docs.