ubyssey / ubyssey.ca

The code that powers www.ubyssey.ca
GNU General Public License v2.0
35 stars 40 forks source link

Fix Guide 2020 template #1456

Open SamuelmdLow opened 1 month ago

SamuelmdLow commented 1 month ago

Example: https://ubyssey.ca/guide/2020/academics/the-basics/

Its broken, would be nice if it wasn't broken!

SamuelmdLow commented 1 month ago

This template does not work because it tries to use the reverse url function to get to the landing pages. But wagtail does not automatically set url pattern names for the page. To fix this we can hardcode the urls in ubyssey.ca/ubyssey/templates/guide/2020/header.html

There are some styling changes to make as well such as the images being commented out in ubyssey.ca/article/templates/article/objects/guide/article-box2022.html. The images are supposed to be used in guide 2020 but aren't in guide 2022 which also uses this block. We can get both to work as intended by making style="background-image: url('{{ image }}');" conditional to image being in the context ({% if image %}, and then going to ubyssey.ca/article/templates/article/article_page_guide_2022.html and remove image=prev_image.url and image=next_image.url from the context

The social media link styling is also off. You can look at ubyssey.ca/article/templates/article/objects/share_bar.html to see working link styling