search

uc-cdis / dictionaryutils

python wrapper and metaschema for datadictionary
Apache License 2.0
4 stars 7 forks source link

PXD-1962 ⁃ add name-length check to dictionary validation script #22

Open philloooo opened 6 years ago

philloooo commented 6 years ago

Dictionary validation does not detect node names that are too long for postgres - ex:


IdentifierError: Identifier 'node_impulsivecompulsivedisordersquestionnaire__sysan__props_idx' exceeds maximum length of 63 characters
philloooo commented 6 years ago

we should just shorten the name, gdcdatamodel already do this for edge table

https://github.com/uc-cdis/gdcdatamodel/blob/develop/gdcdatamodel/models/__init__.py#L372

philloooo commented 6 years ago

➤ Benjamin Rohrer commented:

[~phillis.tt@gmail.com], in the code you linked, the author comments "This is rather an undesirable workaround". Are we sure want to replicate it?