uc-cdis / fence

AuthN/AuthZ OIDC Service
Apache License 2.0
38 stars 48 forks source link

Add debug log #1151

Closed paulineribeyre closed 4 months ago

paulineribeyre commented 4 months ago

Link to JIRA ticket if there is one:

TODO: change authutils dependency to https://github.com/uc-cdis/authutils/pull/77

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

paulineribeyre commented 4 months ago

need to merge https://github.com/uc-cdis/fence/pull/1116 and then update this branch so the unit tests run

paulineribeyre commented 4 months ago

fence pods failing to come up with:

spawned uWSGI worker 2 (pid: 1738, cores: 1)
*** Stats server enabled on 127.0.0.1:9191 fd: 11 ***
Traceback (most recent call last):
  File "/fence/wsgi.py", line 1, in <module>
    from fence import app_init, app
  File "/fence/fence/__init__.py", line 11, in <module>
    from authutils.oauth2.client import OAuthClient
  File "/usr/local/lib/python3.9/site-packages/authutils/oauth2/client/__init__.py", line 1, in <module>
    from authutils.oauth2.client.client import OAuthClient
  File "/usr/local/lib/python3.9/site-packages/authutils/oauth2/client/client.py", line 2, in <module>
    from authlib.integrations.flask_client import OAuth as OAuthClient
ModuleNotFoundError: No module named 'authlib.integrations'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
Traceback (most recent call last):
  File "/fence/wsgi.py", line 1, in <module>
    from fence import app_init, app
  File "/fence/fence/__init__.py", line 11, in <module>
    from authutils.oauth2.client import OAuthClient
  File "/usr/local/lib/python3.9/site-packages/authutils/oauth2/client/__init__.py", line 1, in <module>
    from authutils.oauth2.client.client import OAuthClient
  File "/usr/local/lib/python3.9/site-packages/authutils/oauth2/client/client.py", line 2, in <module>
    from authlib.integrations.flask_client import OAuth as OAuthClient
ModuleNotFoundError: No module named 'authlib.integrations'
unable to load app 0 (mountpoint='') (callable not found or import error)
*** no app loaded. going in full dynamic mode ***
--- no python application found, check your startup logs for errors ---

@BedfordWest

paulineribeyre commented 4 months ago

i believe the error above means it installed authlib 1.3.0 (as used in authutils) instead of authlib v0.11_CVE_patch_v1 (which should be used here)

paulineribeyre commented 4 months ago

Unable to upgrade authutils for now because of a conflict with the authlib version:

Because authutils (6.2.5) depends on authlib (>=1.1.0)
 and fence depends on authlib (*) @ git+https://github.com/uc-cdis/authlib@v0.11_CVE_patch_v1, authutils is forbidden.
So, because fence depends on authutils (=6.2.5), version solving failed.

We can upgrade authutils when fence is moved off this authlib patch

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9554018069

Details


Files with Coverage Reduction New Missed Lines %
jwt/utils.py 5 73.68%
auth.py 14 87.58%
<!-- Total: 19 -->
Totals Coverage Status
Change from base Build 9550344446: -0.02%
Covered Lines: 7622
Relevant Lines: 10160

💛 - Coveralls