uc-cdis / fence

AuthN/AuthZ OIDC Service
Apache License 2.0
38 stars 48 forks source link

aws requester pays #1173

Closed MichaelLukowski closed 2 months ago

MichaelLukowski commented 2 months ago

Changing from using https://github.com/uc-cdis/cdis-python-utils/ for generating S3 presigned urls to the new presigned url generator https://github.com/uc-cdis/cirrus/

The main reason this change was made was to enable the requester pays bucket presigned url generation.

To enable requester pays buckets a boolean flag must be added to the bucket configuration. example below

requestor-pays-test-public:
    cred: cdistest
    requester_pays: true
    region: 'us-east-1'

New Features

Improvements

Deployment changes

Dependency updates

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 10581704084

Details


Files with Coverage Reduction New Missed Lines %
blueprints/data/multipart_upload.py 23 26.92%
blueprints/data/indexd.py 33 94.48%
<!-- Total: 56 -->
Totals Coverage Status
Change from base Build 10290555822: 0.06%
Covered Lines: 7803
Relevant Lines: 10358

💛 - Coveralls
mfshao commented 2 months ago

not sure why some unit tests begin to fail all of sudden with seems to be harmless changes... still checking