search

uc-cdis / gen3-helm

Helm charts for Gen3 Deployments
Apache License 2.0
9 stars 23 forks source link

Fix/fence yaml merge #183

Closed EliseCastle23 closed 3 months ago

EliseCastle23 commented 4 months ago

Copy of https://github.com/uc-cdis/gen3-helm/pull/151/files

Changes added on to PR 151: Adjusting the fence public config so it pulls from FENCE_CONFIG_PUBLIC in the values.yaml.

Changing the manifest-fence configmap to "fence-config-public.yaml" so it is properly mounted in the container.

Editing presigned URL to save the fence public config to a file.

New Features

Users will now have the ability to keep sensitive Fence configurations separate from Fence public configurations.

EliseCastle23 commented 3 months ago

Do we need to update base branch as well? Might be some conflicts after that 😬

Thank you! Yes, just updated base branch and it looks like there are no conflicts :) Merging!