search

ucalyptus / Spotify-Recommendation-Engine

Music Recommender System
https://ucalyptus.github.io/Spotify-Recommendation-Engine/
MIT License
235 stars 117 forks source link

Inclusion of login/signup dependency for Flutter clone #29

Closed Rishabh510 closed 4 years ago

Rishabh510 commented 4 years ago

Provide a login/signup dependency for Flutter clone of Spotify.

Any of the following:

  1. REST API
  2. Firebase
  3. Spotify package (https://pub.dev/packages/spotify)
ucalyptus commented 4 years ago

@Rishabh510 https://github.com/rinukkusu/spotify-dart Can this be implemented ?

ucalyptus commented 4 years ago

@Rishabh510 push changes to flutter branch only . not master https://github.com/ucalyptus/Spotify-Recommendation-Engine/tree/flutter

Rishabh510 commented 4 years ago

@Rishabh510 push changes to flutter branch only . not master https://github.com/ucalyptus/Spotify-Recommendation-Engine/tree/flutter

OK👍 So should I create another branch in my fork or make changes in the flutter branch itself?

Rishabh510 commented 4 years ago

@Rishabh510 https://github.com/rinukkusu/spotify-dart Can this be implemented ?

I'll have to test it out before confirming anything as this package has been released only a week ago so errors are bound to exist.

ucalyptus commented 4 years ago

@Rishabh510 https://github.com/rinukkusu/spotify-dart Can this be implemented ?

I'll have to test it out before confirming anything as this package has been released only a week ago so errors are bound to exist.

Ok

ucalyptus commented 4 years ago

@Rishabh510 push changes to flutter branch only . not master https://github.com/ucalyptus/Spotify-Recommendation-Engine/tree/flutter

OK+1 So should I create another branch in my fork or make changes in the flutter branch itself?

create a branch in ur fork from upstream's flutter branch and create a PR onto it.

joardar-aditya commented 4 years ago

Having checked the spotify authorisation documentation. The implicit grant method flow would be the best for an application i guess. Where we can request for a token by redirecting the user from the app to the spotify website and then getting back the web credentials in the app! Can this be done?

Potential17 commented 4 years ago

Hey, I would like to work on this.

ucalyptus commented 4 years ago

Updates @joardar-aditya and @Potential17 ?

joardar-aditya commented 4 years ago

What is the final ui decided for the app?

ucalyptus commented 4 years ago

@AbhilashG97 feel free to comment.

Potential17 commented 4 years ago

Kindly allow some more time, Will present it to you by this week.

ucalyptus commented 4 years ago

@Potential17 any updates?

Potential17 commented 4 years ago

https://github.com/Potential17/Flutter-app Just some minors to fix

ucalyptus commented 4 years ago

awaiting a PR. only way i can review

Potential17 commented 4 years ago

sure

Rukmini-Meda commented 4 years ago

I would like to work on this issue if its not done. Please assign this to me as part of GSSoC'20. I can make PR early

Potential17 commented 4 years ago

@ucalyptus A PR created yesterday already. Check it.