search

ucalyptus / Spotify-Recommendation-Engine

Music Recommender System
https://ucalyptus.github.io/Spotify-Recommendation-Engine/
MIT License
233 stars 117 forks source link

Github Action workflows for Flutter. #98

Closed ucalyptus2 closed 3 years ago

hpnightowl commented 3 years ago

can i take this issue? as the part of SWOC?

ucalyptus2 commented 3 years ago

Sure

ucalyptus2 commented 3 years ago

@hpnightowl has to be done in the app branch of the repo where flutter code will reside and can be only done when https://github.com/ucalyptus/Spotify-Recommendation-Engine/pull/97 is merged.

hpnightowl commented 3 years ago

ok i will keep and eye on that PR as soon as it will be merged i will PR github action

ucalyptus commented 3 years ago

@hpnightowl you can go ahead now.

ucalyptus commented 3 years ago

@hpnightowl remove these workflows first https://github.com/ucalyptus/Spotify-Recommendation-Engine/tree/app/.github/workflows

hpnightowl commented 3 years ago

ok

hpnightowl commented 3 years ago

@ucalyptus but those workflows are not needed now? I can see it was updated 4 hours ago

ucalyptus commented 3 years ago

The app branch doesn't need these workflows.

hpnightowl commented 3 years ago

ohk and github action should release the test build also or only for checks?

hpnightowl commented 3 years ago

ping me any more changes are needed and what was expected I will correct it thanks since there were some doubts like we need to build apk also in check ? , and workflow should work for pull request and push (I made for both).

ucalyptus commented 3 years ago

There are so many things involved. I will contact you on Monday. A bit busy.

hpnightowl commented 3 years ago

ok !