ucalyptus / Spotify-Recommendation-Engine

Music Recommender System
https://ucalyptus.github.io/Spotify-Recommendation-Engine/
MIT License
233 stars 117 forks source link

Github Action workflows for Flutter #99

Closed hpnightowl closed 3 years ago

hpnightowl commented 3 years ago

Description

the changes are for github action workflow for flutter and also removes the deprecated workflows Fixes # (https://github.com/ucalyptus/Spotify-Recommendation-Engine/issues/98)

Type of change

How Has This Been Tested?

ucalyptus2 commented 3 years ago

@hpnightowl your CI fails. Are you missing any Github key requirement?

ucalyptus2 commented 3 years ago

@vilsi12 can you examine the code in the flutter branch ? I see that the CI is failing because of some dart errors. Follow this link to find what errors are there.

hpnightowl commented 3 years ago

it fails because of the app i guess

This was caught by the test expectation on the following line: file:///home/runner/work/Spotify-Recommendation-Engine/Spotify-Recommendation-Engine/spotify_clone/test/widget_test.dart line 19 The test description was: Counter increments smoke test

ucalyptus2 commented 3 years ago

it fails because of the app i guess

This was caught by the test expectation on the following line: file:///home/runner/work/Spotify-Recommendation-Engine/Spotify-Recommendation-Engine/spotify_clone/test/widget_test.dart line 19 The test description was: Counter increments smoke test

@hpnightowl noted. https://github.com/ucalyptus/Spotify-Recommendation-Engine/blob/6963e399493c0c10a9e981ef713422465271a87f/spotify_clone/test/widget_test.dart#L19

ucalyptus commented 3 years ago

@vilsi12 pls check why the flutter ci is failing

vilsi12 commented 3 years ago

Yes sir

ucalyptus2 commented 3 years ago

@hpnightowl , @vilsi12 any updates?

hpnightowl commented 3 years ago

@forkbabu it Kinda app issue i guess since i use same flutter workflow for my app and works well :) but may be i may be wrong somewhere.