ucam-department-of-psychiatry / camcops

Cambridge Cognitive and Psychiatric Test Kit (CamCOPS)
Other
12 stars 8 forks source link

Simplified spreadsheet export #229

Closed RudolfCardinal closed 2 years ago

RudolfCardinal commented 2 years ago

Addresses https://github.com/RudolfCardinal/camcops/issues/228.

RudolfCardinal commented 2 years ago

Failing on numpy safety checks. One affects "all version", though (">0") -- not fixable, therefore disable this safety check? Its concern is https://github.com/numpy/numpy/issues/19038. Adding "--ignore 44715" might fix this (not sure where it goes) -- could do that for a few others too, or move the minimum Python version to 3.8 as numpy 1.22.0 isn't available for 3.7.

martinburchell commented 2 years ago

Failing on numpy safety checks. One affects "all version", though (">0") -- not fixable, therefore disable this safety check? Its concern is numpy/numpy#19038. Adding "--ignore 44715" might fix this (not sure where it goes) -- could do that for a few others too, or move the minimum Python version to 3.8 as numpy 1.22.0 isn't available for 3.7.

I'd do what I did for CRATE and stick with 3.7 and numpy 1.21. The ignores go in https://github.com/RudolfCardinal/camcops/blob/simplified_spreadsheet_export/.github/workflows/push-to-repository.yml#L59

We may find some of the warnings go away on Tuesday when the vulnerability database is updated.

RudolfCardinal commented 2 years ago

Thanks; trying again...

RudolfCardinal commented 2 years ago

I have kombu==5.2.2 -- it's not in setup.py, so I guess we should pin that (but do feel free to bump everything to your higher versions!).

martinburchell commented 2 years ago

I have kombu==5.2.2 -- it's not in setup.py, so I guess we should pin that (but do feel free to bump everything to your higher versions!).

I rebuilt my virtualenv with the latest pip and now I don't have any broken dependencies

martinburchell commented 2 years ago

Good to merge from my point of view. I did a quick test and it seems to be working as expected.

RudolfCardinal commented 2 years ago

Thanks!