search

ucam-department-of-psychiatry / camcops

Cambridge Cognitive and Psychiatric Test Kit (CamCOPS)
Other
12 stars 8 forks source link

Non-unique name used for authentication apps #234

Open RudolfCardinal opened 2 years ago

RudolfCardinal commented 2 years ago

If you have multiple CamCOPS instances e.g. using Google Authenticator, they both name themselves "CamCOPS (username)" -- so it's a bit hard to work out if you use >1 server, if you happen to have non-unique usernames on multiple servers, there's a problem in identifying which is which. Should we disambiguate (and if so, does it matter if the name is changed on the server after the user has set up authentication)? This probably affects a very small number of users! :)

martinburchell commented 2 years ago

Currently the name is hard-coded to "CamCOPS: https://github.com/RudolfCardinal/camcops/blob/master/server/camcops_server/cc_modules/cc_forms.py#L2345

If there isn't one already, I suggest we make a config option to name the instance and use that instead of "CamCOPS".

Description of the URI Format. We only store and check the secret key so it shouldn't matter if the user name or App name changes.

Twilio Authy allows me to rename accounts. Google Authenticator may as well.