ucam-department-of-psychiatry / camcops

Cambridge Cognitive and Psychiatric Test Kit (CamCOPS)
Other
12 stars 8 forks source link

Workflow to test launching CherryPy with a self-signed certificate #291

Closed martinburchell closed 1 year ago

martinburchell commented 1 year ago

Originally set up to investigate #290, a new workflow to test launching the server with CherryPy with a self-signed certificate. The matrix of python/Ubuntu versions is overkill and we could reduce it to a single combination to save some energy.

In addition this PR fixes some problems with other workflows:

RudolfCardinal commented 1 year ago

Looks good -- thank you! Maybe worth a safety check in .github/scripts/create_config_file.sh that CAMCOPS_CONFIG_FILE is set (non-blank), now that setting has been moved to another file?

martinburchell commented 1 year ago

Looks good -- thank you! Maybe worth a safety check in .github/scripts/create_config_file.sh that CAMCOPS_CONFIG_FILE is set (non-blank), now that setting has been moved to another file?

It's kind of what the -u switch is supposed to do, though in this case the script doesn't reach the variable until it has launched the server. So instead I'm dumping the value before running the command and this should fail quicker.

RudolfCardinal commented 1 year ago

Sorry, my Bash ignorance -- that looks good.