ucam-department-of-psychiatry / camcops

Cambridge Cognitive and Psychiatric Test Kit (CamCOPS)
Other
12 stars 8 forks source link

In single user mode the upload icon disappears when the network activity log is closed #341

Closed martinburchell closed 3 months ago

martinburchell commented 4 months ago

When in single user mode with the network activity log enabled, the upload icon disappears when the log is closed even if no upload happened.

martinburchell commented 3 months ago

When the Acknowledge failure button on the log box is pressed, the behaviour is the same as if for a successful operation the OK button were pressed. The method LogBox::okClicked is called and this calls accept(), which will send the accepted signal. This will call NetworkManager::logboxFinished which emits the finished signal. This will be picked up by the appropriate CamcopsApp callback, which assumes this means success and will disable the icon. In clinician mode CamcopsApp doesn't listen for success or failure signals from NetworkManager so this doesn't happen.