Incorrect questionnaires are being displayed during task chains

ucam-department-of-psychiatry / camcops

Cambridge Cognitive and Psychiatric Test Kit (CamCOPS)

Other

12 stars 8 forks source link

Incorrect questionnaires are being displayed during task chains #350

Closed martinburchell closed 2 months ago

martinburchell commented 2 months ago

From CPFT AEDS:

We've noticed that the incorrect questionnaires are being displayed sometimes during task chains (e.g. if you look at the most recent two patients on the server, the EDE-Q popped up in the middle of the COIIN task chain just now, and earlier today when ---- was getting a patient to do the clinical task chain they were somehow presented with the CHI-T and SUPPS-P).

Some thoughts:

These task chains are set up with creation method "on demand or abort" so if the task chain was aborted, all of the remaining tasks would have been created.
What happens if one task chain is aborted and a different task chain is started?
ISAAQ-10 prohibits commercial use. What happens if the user hasn't filled in their IP settings?

martinburchell commented 2 months ago

One bug here:

Create a patient on the device
Don't set any IP settings
Navigate to Tasks -> Task Chains -> CPFT Adult Eating Disorders Service -> COIIN-AN
The chain is aborted because ISAAQ-10 prohibits commercial use
Press the back button
The user is presented with CHI-T and SUPPS-P

RudolfCardinal commented 2 months ago

As a simple fix, perhaps the first step is: (1) Have the chain launcher refuse to start if one of its tasks won't (saying "fix your IP settings first"). I forget if this might ever affect scheduled tasks -- I think not (since you can't schedule a chain?). But if so, perhaps (2) we should have a way of server-to-client transfer of IP settings for single-user mode, so end users don't have to worry?

martinburchell commented 2 months ago

As a simple fix, perhaps the first step is: (1) Have the chain launcher refuse to start if one of its tasks won't (saying "fix your IP settings first"). I forget if this might ever affect scheduled tasks -- I think not (since you can't schedule a chain?). But if so, perhaps (2) we should have a way of server-to-client transfer of IP settings for single-user mode, so end users don't have to worry?

We do attempt to do both these things. With 1) the chain initially refuses to start but the subWindowFinishedClosing signal is still handled when the user hits the back button and then the tasks in the chain start up until the one that was prohibited. I think this is easy to fix.

With 2) we leave the IP settings for the administrator to set up on the server side and these are sent to the client so the end user shouldn't have to worry.