Adult Autism Spectrum Quotient (AQ) task

[martinburchell]

@RudolfCardinal which menu(s) do you think this task fits under?

Checklist for new tasks:

• [ ] Add task to relevant menus
• [X] Update docs/source/changelog.rst
• [ ] If the text of the task cannot be submitted here for copyright reasons, there is a template XML file under server/camcops_server/extra_string_templates.

Please [X] all the boxes above that apply

[RudolfCardinal]

Looks good -- am almost there but not quite. In passing, Qt is these days dumping the moc_*.cpp files and the final binary (plus two other autogenerated C++ files) into my source directory. I see there is a MOC_DIR setting; e.g.

• https://doc.qt.io/qt-5/qmake-variable-reference.html#moc-dir
• https://stackoverflow.com/questions/6181142

... what's best practice here (given the potential variety of build setups)? Do you have the same problem? Should I be setting an environment variable, or should we encode this into the .pro file?

[RudolfCardinal]

Changes so far:

• slightly more defensive scoring in case of duff data (shouldn't be possible, but...)
• one bit of HTML was doing a redundant string format operation
• in double-checking it turns out there is an error in the published paper about the "agreement versus disagreement" questionnaires, but the ARC document is correct
• neurodiversity icon/menu added (and AQ added to CPFT AEDS menu) -- necessitating a change in the "all tasks" menu (for now I've used the mathematical inverted-A "for all" symbol)

[martinburchell]

Looks good -- am almost there but not quite. In passing, Qt is these days dumping the moc_*.cpp files and the final binary (plus two other autogenerated C++ files) into my source directory. I see there is a MOC_DIR setting; e.g.

* https://doc.qt.io/qt-5/qmake-variable-reference.html#moc-dir

* https://stackoverflow.com/questions/6181142

... what's best practice here (given the potential variety of build setups)? Do you have the same problem? Should I be setting an environment variable, or should we encode this into the .pro file?

I've seen some inconsistent behaviour here. Sometimes Qt Creator wants to put the build in a 'build' directory. Sometimes it works as it always has done. Changing the build directory can leave things in a right mess. The 'shadow build' checkbox is meant to separate the source from the binaries.

[RudolfCardinal]

Am doing final testing -- having messed up icon transparency and sorted it again... I'll add question numbers as prefixes to match the original. I have also learned std::iota! But is this safe? e.g. const QString& fieldname = Q_PREFIX + QString::number(qnum); -- is the reference not to something transient? I've amended as I was changing this anyway, but if it's safe, I should probably understand this better.

[martinburchell]

Am doing final testing -- having messed up icon transparency and sorted it again... I'll add question numbers as prefixes to match the original. I have also learned std::iota! But is this safe? e.g. const QString& fieldname = Q_PREFIX + QString::number(qnum); -- is the reference not to something transient? I've amended as I was changing this anyway, but if it's safe, I should probably understand this better.

I don't know if it's safe! Valgrind didn't complain when I ran it just now. std::iota is meant to fill the QVector with 1,2,3...50. I've not used it before.

[RudolfCardinal]

OK! If it was unsafe, I think it would be akin to a "dangling pointer" rather than a memory leak. But I was wrong, as follows: it is close to the C++11 feature of rvalue references (e.g. https://www.cprogramming.com/c++11/rvalue-references-and-move-semantics-in-c++11.html), but more specifically it is the longer-standing concept that a const reference to a temporary rvalue prevents the temporary object from being deleted ("const lvalue references") (e.g. https://pvs-studio.com/en/blog/posts/cpp/1006/). So I was being unnecessarily worried. Sorry! (Separately, there was a memory leak via new NameValueOptions() -- I've put that in a QSharedPointer.)

[RudolfCardinal]

And thanks re build options! That seems to have fixed my local mess.