ucam-department-of-psychiatry / crate

Create and use de-identified research databases. Preprocess, extract text, anonymise/de-identify, link, apply natural language processing, query for research, manage consent for contact.
GNU General Public License v3.0
19 stars 7 forks source link

Fix omit/ADD_SRC_HASH conflict detection: only at table level, not ro… #120

Closed RudolfCardinal closed 1 year ago

RudolfCardinal commented 1 year ago

…w level

The check for "OMIT" + the "H" (ADD_SRC_HASH) flags was being performed at data dictionary row level. But if the whole table is being omitted, that combination is OK. There was another table-level check for that. Incorrect row-level check removed.

martinburchell commented 1 year ago

Looks good to me, and with these changes, the draft data dictionary is now generated without error on the CPFT server with the RiO database.