ucan-wg / rs-ucan

Rust implementation of UCAN
Apache License 2.0
62 stars 15 forks source link

Update capabilites in line with Ucan 0.9.0/0.10.0 #105

Closed jsantell closed 1 year ago

jsantell commented 1 year ago

Initial work on updating to support latest capabilities in Ucan spec 0.9.0/0.10.0, with a goal of moving closer to the final serializable shape.

Looking for feedback on:

codecov-commenter commented 1 year ago

Codecov Report

Merging #105 (b4a9ebc) into main (3d30ec8) will increase coverage by 1.31%. The diff coverage is 64.06%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105/graphs/tree.svg?width=650&height=150&src=pr&token=UZ53MKNKJC&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg)](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg) ```diff @@ Coverage Diff @@ ## main #105 +/- ## ========================================== + Coverage 57.10% 58.42% +1.31% ========================================== Files 24 23 -1 Lines 802 849 +47 Branches 196 207 +11 ========================================== + Hits 458 496 +38 + Misses 206 204 -2 - Partials 138 149 +11 ``` | [Impacted Files](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg) | Coverage Δ | | |---|---|---| | [ucan/src/chain.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvY2hhaW4ucnM=) | `62.61% <50.00%> (+0.71%)` | :arrow_up: | | [ucan/src/ucan.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvdWNhbi5ycw==) | `67.36% <50.00%> (-1.45%)` | :arrow_down: | | [ucan/src/capability/semantics.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvY2FwYWJpbGl0eS9zZW1hbnRpY3MucnM=) | `44.79% <62.96%> (+9.14%)` | :arrow_up: | | [ucan/src/capability/data.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvY2FwYWJpbGl0eS9kYXRhLnJz) | `66.10% <66.10%> (ø)` | | | [ucan/src/builder.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvYnVpbGRlci5ycw==) | `78.00% <66.66%> (-1.00%)` | :arrow_down: | | [ucan/src/ipld/ucan.rs](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg#diff-dWNhbi9zcmMvaXBsZC91Y2FuLnJz) | `71.11% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ucan-wg/rs-ucan/pull/105/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ucan-wg)
cdata commented 1 year ago

Oh, should also call out that as of this change we will likely be removing support for UCAN IPLD (to be re-introduced at some future date as the spec is updated to be coherent with v0.10.0+).

jsantell commented 1 year ago

Now with working caveats, testing the cases in the spec.

jsantell commented 1 year ago

Updated: