search

ucb-bar / barstools

Useful utilities for BAR projects
Other
31 stars 16 forks source link

Update MacroCompiler for Chisel 3.4 / FIRRTL 1.4 #92

Closed timsnyder-siv closed 3 years ago

timsnyder-siv commented 3 years ago

FireSim needs MacroCompiler.scala and these are the changes @jackkoenig and I made to get it working with FIRRTL 1.4.

timsnyder-siv commented 3 years ago

I'm realizing that I only pushed our changes to MacroCompiler but it would be good to be able to pass test in sbt project macros. Wondering if that would have caught the issue regarding the need to collect the annotations in barstools.macros.MacroCompilerTransform#execute. I'm updating the build.sbt on my branch and cleaning up Chisel3.4 stuff in the tests for macros too.

colinschmidt commented 3 years ago

There is also a travis failure that is potentially related.

timsnyder-siv commented 3 years ago

Updating build.sbt and runinng project macros; test in sbt shows that barstools.macros.GenerateSomeVerilog is failing because the verilog generated is empty. It took me awhile looking at the testing code to understand that this is probably the collection thing @jackkoenig noticed and already mentioned. I pushed my update to build.sbt and the macros tests but now it seems like there are conflicts with the firrtl-1.4-remove-clk-stuff branch. I'm going to merge that branch into mine and repush.

timsnyder-siv commented 3 years ago

Hmmm. Not sure why I have a couple of tests failing in the tapeout namespace failing after merging the firrtl-1.4-remove-clk-stuff branch into this PR. I'll try to reproduce that locally. It was my first time using the github web UI to merge and resolve conflicts. Perhaps I pooched something.